Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2754513002: Roll libyuv 0741a3d..2adb84e (Closed)

Created:
3 years, 9 months ago by fbarchard1
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll libyuv 0741a3d..2adb84e Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/0741a3d..2adb84e This allows libyuv unittests to build without gflags. BUG=libyuv:691 TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" R=kjellander@chromium.org, thakis@chromium.org Review-Url: https://codereview.chromium.org/2754513002 . Cr-Commit-Position: refs/heads/master@{#457837} Committed: https://chromium.googlesource.com/chromium/src/+/404ba0c71f7fe2b59657067a6d3f5f7909cd920d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
fbarchard1
works as expected: gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" ninja -v -C out/Release libyuv_unittest ...
3 years, 9 months ago (2017-03-15 21:51:48 UTC) #11
kjellander_chromium
I updated the CL description to make it clear this is a roll CL. lgtm
3 years, 9 months ago (2017-03-16 07:37:09 UTC) #13
Nico
lgtm I filed https://bugs.llvm.org/show_bug.cgi?id=32312 for clang-format slaughtering your code :'-(
3 years, 9 months ago (2017-03-16 15:12:59 UTC) #15
fbarchard1
3 years, 9 months ago (2017-03-17 19:00:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
404ba0c71f7fe2b59657067a6d3f5f7909cd920d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698