|
|
Created:
3 years, 9 months ago by fbarchard1 Modified:
3 years, 9 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll libyuv 0741a3d..2adb84e
Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/0741a3d..2adb84e
This allows libyuv unittests to build without gflags.
BUG=libyuv:691
TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false"
R=kjellander@chromium.org, thakis@chromium.org
Review-Url: https://codereview.chromium.org/2754513002 .
Cr-Commit-Position: refs/heads/master@{#457837}
Committed: https://chromium.googlesource.com/chromium/src/+/404ba0c71f7fe2b59657067a6d3f5f7909cd920d
Patch Set 1 #Messages
Total messages: 17 (13 generated)
The CQ bit was checked by fbarchard@google.com to run a CQ dry run
Description was changed from ========== libyuv allow unittests to build without gflags BUG=libyuv:691 TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" ========== to ========== libyuv allow unittests to build without gflags BUG=libyuv:691 TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" ==========
fbarchard@google.com changed reviewers: + kjellander@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fbarchard@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
works as expected: gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" ninja -v -C out/Release libyuv_unittest LIBYUV_REPEAT=1000 out/Release/libyuv_unittest --gtest_filter=*HalfFloat*Note: Google Test filter = *HalfFloat* [==========] Running 9 tests from 1 test case. [----------] Global test environment set-up. [----------] 9 tests from LibYUVPlanarTest [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_denormal (24695 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_One [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_One (601 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_Opt [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_16bit_Opt (600 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_10bit_Opt [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_10bit_Opt (620 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_9bit_Opt [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_9bit_Opt (600 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_Opt [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_Opt (600 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_Offby1 [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_Offby1 (599 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_One [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_One (599 ms) [ RUN ] LibYUVPlanarTest.TestHalfFloatPlane_12bit_One [ OK ] LibYUVPlanarTest.TestHalfFloatPlane_12bit_One (599 ms) [----------] 9 tests from LibYUVPlanarTest (29514 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test case ran. (29515 ms total) [ PASSED ] 9 tests.
Description was changed from ========== libyuv allow unittests to build without gflags BUG=libyuv:691 TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" ========== to ========== Roll libyuv 0741a3d..2adb84e Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/0741a3d..2adb84e This allows libyuv unittests to build without gflags. BUG=libyuv:691 TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" ==========
I updated the CL description to make it clear this is a roll CL. lgtm
thakis@chromium.org changed reviewers: + thakis@chromium.org
lgtm I filed https://bugs.llvm.org/show_bug.cgi?id=32312 for clang-format slaughtering your code :'-(
Description was changed from ========== Roll libyuv 0741a3d..2adb84e Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/0741a3d..2adb84e This allows libyuv unittests to build without gflags. BUG=libyuv:691 TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" ========== to ========== Roll libyuv 0741a3d..2adb84e Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/0741a3d..2adb84e This allows libyuv unittests to build without gflags. BUG=libyuv:691 TEST=gn gen out/Release "--args=is_debug=false target_cpu=\"x64\" libyuv_include_tests=true libyuv_use_gflags=false" R=kjellander@chromium.org, thakis@chromium.org Review-Url: https://codereview.chromium.org/2754513002 . Cr-Commit-Position: refs/heads/master@{#457837} Committed: https://chromium.googlesource.com/chromium/src/+/404ba0c71f7fe2b59657067a6d3f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 404ba0c71f7fe2b59657067a6d3f5f7909cd920d (presubmit successful). |