Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2754473007: Make the gdb Vector pretty-printer work with Python version >= 3. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the gdb Vector pretty-printer work with Python version >= 3. In iterators it's now called __next__(), not next(), apparently. Review-Url: https://codereview.chromium.org/2754473007 Cr-Commit-Position: refs/heads/master@{#457711} Committed: https://chromium.googlesource.com/chromium/src/+/6c2939ade3de360100011544d5600adc49013a31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Tools/gdb/webkit.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-16 11:00:36 UTC) #2
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-16 23:31:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754473007/1
3 years, 9 months ago (2017-03-17 06:51:47 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 07:50:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c2939ade3de360100011544d560...

Powered by Google App Engine
This is Rietveld 408576698