Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2754463004: [Android] Strip 'DISABLED_' test name prefix for gtest (Closed)

Created:
3 years, 9 months ago by shenghuazhang
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, stgao
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Strip 'DISABLED_' test name prefix for gtest Currently the gtest results output has the 'DISABLED_' prefix on disabled tests. This CL strips the 'DISABLED_' prefix for gtest results output, which matches gtest results on desktop produced by //base/test/launcher. BUG=698143 Review-Url: https://codereview.chromium.org/2754463004 Cr-Commit-Position: refs/heads/master@{#457155} Committed: https://chromium.googlesource.com/chromium/src/+/d0287a23d5d61345ca9c246b5119ab78e80305eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
shenghuazhang
3 years, 9 months ago (2017-03-14 23:13:32 UTC) #2
mikecase (-- gone --)
lgtm
3 years, 9 months ago (2017-03-15 01:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754463004/1
3 years, 9 months ago (2017-03-15 17:34:57 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:58:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0287a23d5d61345ca9c246b5119...

Powered by Google App Engine
This is Rietveld 408576698