Do more strict checking when calling into MathJaX

Do more strict checking when calling into MathJaX

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2754363003
Cr-Commit-Position: refs/heads/master@{#458236}
Committed: https://chromium.googlesource.com/chromium/src/+/1e092376b3a4416c00e35b097052bd2fe5e118bd

[David Tseng, 2017-03-18 00:29:22]

Description was changed from

==========
Do more strict checking when calling into MathJaX

BUG=
==========

to

==========
Do more strict checking when calling into MathJaX

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-03-18 00:31:34]

Description was changed from

==========
Do more strict checking when calling into MathJaX

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Do more strict checking when calling into MathJaX

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-03-18 00:31:34]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[chromium-reviews, 2017-03-18 20:27:02]

+ /**
> + * @param {string} path
> + * @return {*}
> + */
> + function getPath(path) {


Just happened to see this and I remember that Closure has an equivalent 
function:
goog.getObjectByName = function(name, opt_obj) { |  }
I think that ChromeVox uses Closure, but perhaps I am mistaken.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-03-20 18:16:15]

lgtm

https://codereview.chromium.org/2754363003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js
(right):

https://codereview.chromium.org/2754363003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js:135:
function getPath(path) {
Could you name this something more clear and/or add
docstring? "Path" is an overloaded term. How about
resolveGlobalPath?

https://codereview.chromium.org/2754363003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js:141:
return null;
nit: indent

[dmazzoni, 2017-03-20 18:16:57]

Calling it getObjectByName, for similarity with
Closure, sounds good too. (We don't use all of
Closure but using the same name might make sense.)

[David Tseng, 2017-03-20 20:53:40]

On 2017/03/20 18:16:57, dmazzoni wrote:
> Calling it getObjectByName, for similarity with
> Closure, sounds good too. (We don't use all of
> Closure but using the same name might make sense.)

Ok, renamed, though it is hidden by the outer closure, so private to this block.
This file runs in the page context, so no, Closure isn't available.

[David Tseng, 2017-03-20 21:01:05]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-03-20 21:01:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2754363003/#ps20001
(title: "Address nits.")

[commit-bot: I haz the power, 2017-03-20 21:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:31:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490043665541110,
"parent_rev": "827113d59cf7e13e27ea2e3e102adb0789c55500", "commit_rev":
"1e092376b3a4416c00e35b097052bd2fe5e118bd"}

[commit-bot: I haz the power, 2017-03-20 23:32:14]

Description was changed from

==========
Do more strict checking when calling into MathJaX

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Do more strict checking when calling into MathJaX

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2754363003
Cr-Commit-Position: refs/heads/master@{#458236}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e092376b3a4416c00e35b097052...
==========

[commit-bot: I haz the power, 2017-03-20 23:32:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e092376b3a4416c00e35b097052...