Chromium Code Reviews
DescriptionDon't focus the omnibox when a subframe navigates on NTP (Merge to M58)
This fixes a bug where an NTP replacement page from an extension was
losing focus to the omnibox when a subframe on that page committed a
navigation. So if the user was typing into an <input> on the NTP
replacement page while a subframe navigated, the focus was
disruptively shifted to the omnibox in the middle of typing.
This matters only in OOPIF modes, as focusing of the omnibox was done
in RenderFrameHostManager::CommitPending, which is only used for
cross-process commits.
BUG=700124
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2748103005
Cr-Commit-Position: refs/heads/master@{#457222}
(cherry picked from commit 5e8b5e6aebcb564897e311ae4f4397eed3555457)
Review-Url: https://codereview.chromium.org/2754363002 .
Cr-Commit-Position: refs/branch-heads/3029@{#270}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/ac6993fe1faea8121d6584815eaae580921bcbc7
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||