Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Side by Side Diff: components/password_manager/core/browser/credential_manager_password_form_manager.h

Issue 2754273003: Introduce restricted PasswordFormManager::GrabFetcher (Closed)
Patch Set: Remove redundant CredentialManagerPasswordFormManager::form_fetcher_ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/credential_manager_password_form_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "components/password_manager/core/browser/password_form_manager.h" 10 #include "components/password_manager/core/browser/password_form_manager.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 std::unique_ptr<autofill::PasswordForm> saved_form, 45 std::unique_ptr<autofill::PasswordForm> saved_form,
46 CredentialManagerPasswordFormManagerDelegate* delegate, 46 CredentialManagerPasswordFormManagerDelegate* delegate,
47 std::unique_ptr<FormSaver> form_saver, 47 std::unique_ptr<FormSaver> form_saver,
48 std::unique_ptr<FormFetcher> form_fetcher); 48 std::unique_ptr<FormFetcher> form_fetcher);
49 ~CredentialManagerPasswordFormManager() override; 49 ~CredentialManagerPasswordFormManager() override;
50 50
51 void ProcessMatches( 51 void ProcessMatches(
52 const std::vector<const autofill::PasswordForm*>& non_federated, 52 const std::vector<const autofill::PasswordForm*>& non_federated,
53 size_t filtered_count) override; 53 size_t filtered_count) override;
54 54
55 #if defined(UNIT_TEST)
56 FormFetcher* form_fetcher() const { return form_fetcher_.get(); }
57 #endif // defined(UNIT_TEST)
58
59 private: 55 private:
60 // Calls OnProvisionalSaveComplete on |delegate_|. 56 // Calls OnProvisionalSaveComplete on |delegate_|.
61 void NotifyDelegate(); 57 void NotifyDelegate();
62 58
63 CredentialManagerPasswordFormManagerDelegate* delegate_; 59 CredentialManagerPasswordFormManagerDelegate* delegate_;
64 std::unique_ptr<autofill::PasswordForm> saved_form_; 60 std::unique_ptr<autofill::PasswordForm> saved_form_;
65 std::unique_ptr<FormFetcher> form_fetcher_;
66 61
67 base::WeakPtrFactory<CredentialManagerPasswordFormManager> weak_factory_; 62 base::WeakPtrFactory<CredentialManagerPasswordFormManager> weak_factory_;
68 63
69 DISALLOW_COPY_AND_ASSIGN(CredentialManagerPasswordFormManager); 64 DISALLOW_COPY_AND_ASSIGN(CredentialManagerPasswordFormManager);
70 }; 65 };
71 66
72 } // namespace password_manager 67 } // namespace password_manager
73 68
74 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_ FORM_MANAGER_H_ 69 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_ FORM_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/core/browser/credential_manager_password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698