Add OpenVR SDK to third_party

Add OpenVR SDK to third_party

This change adds third_party/openvr so we can target OpenVR on desktop.

As said in README.chromium, this is a copy of files from the OpenVR git repository.

BUG=644793
Review-Url: https://codereview.chromium.org/2754253003
Cr-Commit-Position: refs/heads/master@{#476204}
Committed: https://chromium.googlesource.com/chromium/src/+/59fa2d9df6df0450d142cea1364b1fb73eb535d0

[billorr, 2017-03-18 00:10:44]

https://codereview.chromium.org/2754253003/diff/1/third_party/openvr/BUILD.gn
File third_party/openvr/BUILD.gn (right):

https://codereview.chromium.org/2754253003/diff/1/third_party/openvr/BUILD.gn...
third_party/openvr/BUILD.gn:1: # Copyright 2016 The Chromium Authors.  All
rights reserved.
2017

also, double check for Copyright in other files

[billorr, 2017-03-21 20:26:43]

https://codereview.chromium.org/2754253003/diff/1/third_party/openvr/BUILD.gn
File third_party/openvr/BUILD.gn (right):

https://codereview.chromium.org/2754253003/diff/1/third_party/openvr/BUILD.gn...
third_party/openvr/BUILD.gn:1: # Copyright 2016 The Chromium Authors.  All
rights reserved.
On 2017/03/18 00:10:44, billorr wrote:
> 2017
> 
> also, double check for Copyright in other files

Done.

[billorr, 2017-03-21 20:34:44]

billorr@chromium.org changed reviewers:
+ bajones@chromium.org, ddorwin@chromium.org

[billorr, 2017-03-21 20:34:45]

PTAL. I'll be sending out for security/legal, and follow up with eng-reviews
shortly.

[billorr, 2017-03-21 20:46:00]

Description was changed from

==========
WebVR desktop: integrate with final Valve source and upstream it

This change adds a third_party/openvr so we can target OpenVR on desktop.

BUG=644793
==========

to

==========
Add OpenVR SDK to third_party

This change adds third_party/openvr so we can target OpenVR on desktop.

As said in README.chromium, this is a copy of files from the OpenVR git
repository.

BUG=644793
==========

[ddorwin, 2017-03-21 21:05:07]

https://codereview.chromium.org/2754253003/diff/10001/third_party/openvr/BUIL...
File third_party/openvr/BUILD.gn (right):

https://codereview.chromium.org/2754253003/diff/10001/third_party/openvr/BUIL...
third_party/openvr/BUILD.gn:8: configs -= [ "//build/config/win:unicode" ]
Explain this and the next item.

[billorr, 2017-03-21 21:30:51]

billorr@chromium.org changed reviewers:
+ jochen@chromium.org

[billorr, 2017-03-21 21:30:52]

jochen@chromium.org: Please review changes in third_party.

[billorr, 2017-03-21 21:36:39]

https://codereview.chromium.org/2754253003/diff/10001/third_party/openvr/BUIL...
File third_party/openvr/BUILD.gn (right):

https://codereview.chromium.org/2754253003/diff/10001/third_party/openvr/BUIL...
third_party/openvr/BUILD.gn:8: configs -= [ "//build/config/win:unicode" ]
On 2017/03/21 21:05:07, ddorwin wrote:
> Explain this and the next item.

Done.

[bajones, 2017-03-21 22:59:39]

Given that OpenVR is available on GitHub and that we don't need to modify it (as
far as I know), we should add this as a DEPS rather than copying the files into
third_party directly. You can look at the initial commit adding gvr to
third_party as an example:
https://chromium.googlesource.com/chromium/src/+/c690d9acd621580286df87ce7851...

We'll also want to create a mirror of the OpenVR git repo to point to instead of
the GitHub repo directly. See the "Ask the infrastructure team to add a git
mirror for the dependency" of
https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_th...
for more details.

[billorr, 2017-03-21 23:06:18]

On 2017/03/21 22:59:39, bajones wrote:
> Given that OpenVR is available on GitHub and that we don't need to modify it
(as
> far as I know), we should add this as a DEPS rather than copying the files
into
> third_party directly. You can look at the initial commit adding gvr to
> third_party as an example:
>
https://chromium.googlesource.com/chromium/src/+/c690d9acd621580286df87ce7851...
> 
> We'll also want to create a mirror of the OpenVR git repo to point to instead
of
> the GitHub repo directly. See the "Ask the infrastructure team to add a git
> mirror for the dependency" of
>
https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_th...
> for more details.

That is what I started with.  The problem is the git repo brings in several
hundred megabytes of things we don't need (.lib files, samples).  This approach
keeps the checkout size smaller.

We could try to fork the repo, delete the files we don't need, and handle
merges.  This approach seems simpler.

[bajones, 2017-03-21 23:10:23]

Ok, I didn't realize that. I wonder if there's a reasonable way to ignore
certain files or directories in the mirror and/or DEPS checkout? Might be worth
creating the infra ticket for a mirror anyway and explicitly ask if theres a way
to exclude items.

If not this probably is the better approach.

[billorr, 2017-03-21 23:16:32]

On 2017/03/21 23:10:23, bajones wrote:
> Ok, I didn't realize that. I wonder if there's a reasonable way to ignore
> certain files or directories in the mirror and/or DEPS checkout? Might be
worth
> creating the infra ticket for a mirror anyway and explicitly ask if theres a
way
> to exclude items.
> 
> If not this probably is the better approach.

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=703877 to see if
there is a way to exclude unneeded files.

[jochen (gone - plz use gerrit), 2017-03-22 10:04:00]

will you need additional things to actually use this, e.g., will developers need
to have the dll installed locally?

can you contact the chrome infra folks directly to get a timely response on
whether a git mirror would be an option?

[billorr, 2017-03-22 17:09:37]

On 2017/03/22 10:04:00, jochen wrote:
> will you need additional things to actually use this, e.g., will developers
need
> to have the dll installed locally?
> 
> can you contact the chrome infra folks directly to get a timely response on
> whether a git mirror would be an option?

In order to use OpenVR, users will need to have the OpenVR runtime installed,
which is part of the setup process for a Vive or other OpenVR headset.

Developers or users without hardware won't need to install anything extra - the
API components will detect the lack of an installed runtime and return an
appropriate error code that we'll handle.

I've sent a mail to the infra team, I'll reply back here when I hear back.

Thanks,
-Bill

[billorr, 2017-03-23 19:50:15]

On 2017/03/22 17:09:37, billorr wrote:
> On 2017/03/22 10:04:00, jochen wrote:
> > will you need additional things to actually use this, e.g., will developers
> need
> > to have the dll installed locally?
> > 
> > can you contact the chrome infra folks directly to get a timely response on
> > whether a git mirror would be an option?
> 
> In order to use OpenVR, users will need to have the OpenVR runtime installed,
> which is part of the setup process for a Vive or other OpenVR headset.
> 
> Developers or users without hardware won't need to install anything extra -
the
> API components will detect the lack of an installed runtime and return an
> appropriate error code that we'll handle.
> 
> I've sent a mail to the infra team, I'll reply back here when I hear back.
> 
> Thanks,
> -Bill

Got a response from the infra team - guidance is to just check in the subset of
the repo directly (as done here).  There is no method currently for a partial
git checkout/partial mirror.

[jochen (gone - plz use gerrit), 2017-03-23 19:51:14]

ok, thanks for following up on this.

lgtm to land as soon as you have security and opensource clearance

[xam, 2017-03-24 19:50:56]

On 2017/03/23 19:51:14, jochen wrote:
> ok, thanks for following up on this.
> 
> lgtm to land as soon as you have security and opensource clearance

OK from OSTPR

[billorr, 2017-06-01 04:32:55]

The CQ bit was checked by billorr@chromium.org

[commit-bot: I haz the power, 2017-06-01 04:33:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 06:05:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496291575400930,
"parent_rev": "562876f283093f8facece42cafa3defde3d5e000", "commit_rev":
"59fa2d9df6df0450d142cea1364b1fb73eb535d0"}

[commit-bot: I haz the power, 2017-06-01 06:05:41]

Description was changed from

==========
Add OpenVR SDK to third_party

This change adds third_party/openvr so we can target OpenVR on desktop.

As said in README.chromium, this is a copy of files from the OpenVR git
repository.

BUG=644793
==========

to

==========
Add OpenVR SDK to third_party

This change adds third_party/openvr so we can target OpenVR on desktop.

As said in README.chromium, this is a copy of files from the OpenVR git
repository.

BUG=644793

Review-Url: https://codereview.chromium.org/2754253003
Cr-Commit-Position: refs/heads/master@{#476204}
Committed:
https://chromium.googlesource.com/chromium/src/+/59fa2d9df6df0450d142cea1364b...
==========

[commit-bot: I haz the power, 2017-06-01 06:05:46]

Committed patchset #3 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/59fa2d9df6df0450d142cea1364b...