Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2754253002: [tools] gm.py: start goma when it isn't running (Closed)

Created:
3 years, 9 months ago by Jakob Kummerow
Modified:
3 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] gm.py: start goma when it isn't running NOTRY=true Review-Url: https://codereview.chromium.org/2754253002 Cr-Commit-Position: refs/heads/master@{#43904} Committed: https://chromium.googlesource.com/v8/v8/+/94efcfe01be03b3dfc0a8b335aca9d3246ddc016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M tools/dev/gm.py View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jakob Kummerow
PTAL
3 years, 9 months ago (2017-03-17 14:06:44 UTC) #2
Camillo Bruni
lgtm
3 years, 9 months ago (2017-03-17 14:08:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754253002/1
3 years, 9 months ago (2017-03-17 14:08:45 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 14:10:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/94efcfe01be03b3dfc0a8b335aca9d3246d...

Powered by Google App Engine
This is Rietveld 408576698