Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2754203003: Give CSChromium its own bundle identifier. (Closed)

Created:
3 years, 9 months ago by lpromero
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give CSChromium its own bundle identifier. Prior to this CL, CSChromium (clean skeleton) was sharing Chromium's. This means we can now install both alongisde. BUG=none R=sdefresne@chromium.org,marq@chromium.org Review-Url: https://codereview.chromium.org/2754203003 Cr-Commit-Position: refs/heads/master@{#457805} Committed: https://chromium.googlesource.com/chromium/src/+/8e89131b44e689b9992daad893367826ef25616f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/clean/chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
lpromero
3 years, 9 months ago (2017-03-17 14:30:19 UTC) #1
marq (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-17 17:02:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754203003/1
3 years, 9 months ago (2017-03-17 17:27:10 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 17:33:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e89131b44e689b9992daad89336...

Powered by Google App Engine
This is Rietveld 408576698