Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional load fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the completion of loading
the Link Doctor error page would be at race with that of subsequent navigations
initiated in the test, leading to flakiness.

BUG=637415, 700514
Review-Url: https://codereview.chromium.org/2754173003
Cr-Commit-Position: refs/heads/master@{#457796}
Committed: https://chromium.googlesource.com/chromium/src/+/0485e8ec0ab7d527744dcd61328b7f23a1eecfda

[engedy, 2017-03-17 09:46:35]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 09:46:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2017-03-17 09:47:39]

Description was changed from

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the Link Doctor error
page finishing loading would be at race with the completion of the subsequent
navigation in the test, leading to flakiness.

BUG=637415,700514
==========

to

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the Link Doctor error
page finishing loading would be at race with the completion of the subsequent
navigation initiated afterwards by the test, leading to flakiness.

BUG=637415,700514
==========

[engedy, 2017-03-17 09:47:39]

engedy@chromium.org changed reviewers:
+ mmenke@chromium.org

[engedy, 2017-03-17 09:48:41]

Matt, could you please take a quick look?

[commit-bot: I haz the power, 2017-03-17 10:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:26:08]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-03-17 16:09:28]

On 2017/03/17 09:48:41, engedy wrote:
> Matt, could you please take a quick look?

LGTM!

[engedy, 2017-03-17 16:32:05]

Description was changed from

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the Link Doctor error
page finishing loading would be at race with the completion of the subsequent
navigation initiated afterwards by the test, leading to flakiness.

BUG=637415,700514
==========

to

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional load fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the Link Doctor error
page finishing loading would be at race with the completion of the subsequent
navigation initiated afterwards by the test, leading to flakiness.

BUG=637415,700514
==========

[engedy, 2017-03-17 16:33:39]

Description was changed from

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional load fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the Link Doctor error
page finishing loading would be at race with the completion of the subsequent
navigation initiated afterwards by the test, leading to flakiness.

BUG=637415,700514
==========

to

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional load fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the completion of loading
the Link Doctor error page would be at race with that of subsequent navigations
initiated in the test, leading to flakiness.

BUG=637415,700514
==========

[engedy, 2017-03-17 16:43:54]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:44:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 16:49:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489769034842770, "parent_rev":
"7ad66d248909da6cfdf6d24147e8d097b1bb6202", "commit_rev":
"0485e8ec0ab7d527744dcd61328b7f23a1eecfda"}

[commit-bot: I haz the power, 2017-03-17 16:49:51]

Description was changed from

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional load fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the completion of loading
the Link Doctor error page would be at race with that of subsequent navigations
initiated in the test, leading to flakiness.

BUG=637415,700514
==========

to

==========
Make SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe non-flaky.

When a provisional load fails with no server-supplied error page, Chrome's own
navigation error page is shown. This also triggers a background request to load
navigation corrections (aka. Link Doctor). Once the results are back, there is
a navigation to a second error page with the suggestions.

Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe
expect and wait for this second navigation. Otherwise the completion of loading
the Link Doctor error page would be at race with that of subsequent navigations
initiated in the test, leading to flakiness.

BUG=637415,700514

Review-Url: https://codereview.chromium.org/2754173003
Cr-Commit-Position: refs/heads/master@{#457796}
Committed:
https://chromium.googlesource.com/chromium/src/+/0485e8ec0ab7d527744dcd61328b...
==========

[commit-bot: I haz the power, 2017-03-17 16:49:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0485e8ec0ab7d527744dcd61328b...