Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2754163002: GPU OWNERS maintainance (Closed)

Created:
3 years, 9 months ago by piman
Modified:
3 years, 9 months ago
Reviewers:
Fady Samuel, vmiura
CC:
chromium-reviews, rjkroege, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

GPU OWNERS maintainance 1- replace dyen@ (who left the project) by vmiura@ 2- remove content/common/gpu/ since it's empty 3- move Internals>GPU component (dumping ground) to more accurate component (mostly Internals>GPU>Internals except for content/renderer/gpu that goes to Blink>Compositing) BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2754163002 Cr-Commit-Position: refs/heads/master@{#457857} Committed: https://chromium.googlesource.com/chromium/src/+/dd42664ce773ac1869030184955a2ef094b41f31

Patch Set 1 #

Total comments: 2

Patch Set 2 : Blink>Compositing -> Internals>Compositing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M content/browser/gpu/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/OWNERS View 1 chunk +0 lines, -11 lines 0 comments Download
M content/gpu/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/GLES2/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/vulkan/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/gpu/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/SPIRV-Tools/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/glslang/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/shaderc/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/vulkan/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
piman
vmiura: please review (tag you're it as secondary OWNER for Vulkan-related things) fsamuel: services/ui/gpu
3 years, 9 months ago (2017-03-16 21:00:47 UTC) #3
Fady Samuel
lgtm
3 years, 9 months ago (2017-03-16 21:09:47 UTC) #4
vmiura
LGTM % one comment. https://codereview.chromium.org/2754163002/diff/1/content/renderer/gpu/OWNERS File content/renderer/gpu/OWNERS (right): https://codereview.chromium.org/2754163002/diff/1/content/renderer/gpu/OWNERS#newcode6 content/renderer/gpu/OWNERS:6: # COMPONENT: Blink>Compositing I'm not ...
3 years, 9 months ago (2017-03-16 21:57:18 UTC) #5
piman
https://codereview.chromium.org/2754163002/diff/1/content/renderer/gpu/OWNERS File content/renderer/gpu/OWNERS (right): https://codereview.chromium.org/2754163002/diff/1/content/renderer/gpu/OWNERS#newcode6 content/renderer/gpu/OWNERS:6: # COMPONENT: Blink>Compositing On 2017/03/16 21:57:17, vmiura wrote: > ...
3 years, 9 months ago (2017-03-17 19:23:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754163002/20001
3 years, 9 months ago (2017-03-17 19:23:48 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 19:43:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd42664ce773ac1869030184955a...

Powered by Google App Engine
This is Rietveld 408576698