Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1168)

Issue 2754143003: For a "cancel" of an alert dialog via HandleJavaScriptDialog, click the only button, "OK". (Closed)

Created:
1 year, 1 month ago by Avi (use Gerrit)
Modified:
1 year, 1 month ago
Reviewers:
samuong, dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

For a "cancel" of an alert dialog via HandleJavaScriptDialog, click the only button, "OK". This keeps us from crashing. BUG=702290 Review-Url: https://codereview.chromium.org/2754143003 Cr-Commit-Position: refs/heads/master@{#457556} Committed: https://chromium.googlesource.com/chromium/src/+/0e43eca719311f3a873d5c8bc644a77465450e21

Patch Set 1 #

Patch Set 2 : fully qualify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M components/app_modal/javascript_dialog_manager.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Avi (use Gerrit)
1 year, 1 month ago (2017-03-16 19:20:05 UTC) #8
samuong
lgtm
1 year, 1 month ago (2017-03-16 19:58:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754143003/20001
1 year, 1 month ago (2017-03-16 20:11:32 UTC) #12
commit-bot: I haz the power
1 year, 1 month ago (2017-03-16 21:17:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e43eca719311f3a873d5c8bc644...

Powered by Google App Engine
This is Rietveld 408576698