components/offline_pages/core/offline_page_model.cc - Issue 2754103003: Adds metric to help assess last_n impact on tab restores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/offline_page_model.cc

Issue 2754103003: Adds metric to help assess last_n impact on tab restores. (Closed)

Patch Set: Removed canSaveUrl method because it was already implemented elsewhere. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/offline_page_model.cc

diff --git a/components/offline_pages/core/offline_page_model.cc b/components/offline_pages/core/offline_page_model.cc

index e8d7edeb33bd3ca59a80c19251023e51a5b17b6e..2fc3130f3c6523227a49ef26e3ded3b5c0846ecc 100644

--- a/components/offline_pages/core/offline_page_model.cc

+++ b/components/offline_pages/core/offline_page_model.cc

@@ -24,6 +24,8 @@ OfflinePageModel::SavePageParams::SavePageParams(const SavePageParams& other) {

// static

bool OfflinePageModel::CanSaveURL(const GURL& url) {

+ // Note: Must be kept in sync with Java implementation in

fgorski 2017/03/17 03:42:51 remove, please.

carlosk 2017/03/17 20:37:22 Done.

+ // OfflinePageUtils.CanSaveOnlineUrl.

return url.is_valid() && url.SchemeIsHTTPOrHTTPS();

}