Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: components/offline_pages/core/offline_page_model.cc

Issue 2754103003: Adds metric to help assess last_n impact on tab restores. (Closed)
Patch Set: Removed canSaveUrl method because it was already implemented elsewhere. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/offline_page_model.h" 5 #include "components/offline_pages/core/offline_page_model.h"
6 6
7 #include "url/gurl.h" 7 #include "url/gurl.h"
8 8
9 namespace offline_pages { 9 namespace offline_pages {
10 10
11 const int64_t OfflinePageModel::kInvalidOfflineId; 11 const int64_t OfflinePageModel::kInvalidOfflineId;
12 12
13 OfflinePageModel::SavePageParams::SavePageParams() 13 OfflinePageModel::SavePageParams::SavePageParams()
14 : proposed_offline_id(OfflinePageModel::kInvalidOfflineId), 14 : proposed_offline_id(OfflinePageModel::kInvalidOfflineId),
15 is_background(false) {} 15 is_background(false) {}
16 16
17 OfflinePageModel::SavePageParams::SavePageParams(const SavePageParams& other) { 17 OfflinePageModel::SavePageParams::SavePageParams(const SavePageParams& other) {
18 url = other.url; 18 url = other.url;
19 client_id = other.client_id; 19 client_id = other.client_id;
20 proposed_offline_id = other.proposed_offline_id; 20 proposed_offline_id = other.proposed_offline_id;
21 original_url = other.original_url; 21 original_url = other.original_url;
22 is_background = other.is_background; 22 is_background = other.is_background;
23 } 23 }
24 24
25 // static 25 // static
26 bool OfflinePageModel::CanSaveURL(const GURL& url) { 26 bool OfflinePageModel::CanSaveURL(const GURL& url) {
27 // Note: Must be kept in sync with Java implementation in
fgorski 2017/03/17 03:42:51 remove, please.
carlosk 2017/03/17 20:37:22 Done.
28 // OfflinePageUtils.CanSaveOnlineUrl.
27 return url.is_valid() && url.SchemeIsHTTPOrHTTPS(); 29 return url.is_valid() && url.SchemeIsHTTPOrHTTPS();
28 } 30 }
29 31
30 OfflinePageModel::OfflinePageModel() {} 32 OfflinePageModel::OfflinePageModel() {}
31 33
32 OfflinePageModel::~OfflinePageModel() {} 34 OfflinePageModel::~OfflinePageModel() {}
33 35
34 } // namespace offline_pages 36 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698