Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2754103002: Add XFA pdfium fuzzer (Closed)

Created:
3 years, 9 months ago by dsinclair
Modified:
3 years, 8 months ago
CC:
chromium-reviews, fuzzing_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add XFA pdfium fuzzer This CL updates the pdfium_fuzzer to also build in the needed XFA code. The BUILD file is changed to only build pdfium_fuzzer if we're not in XFA and build pdfium_xfa_fuzzer if we're in XFA. Review-Url: https://codereview.chromium.org/2754103002 Cr-Commit-Position: refs/heads/master@{#459186} Committed: https://chromium.googlesource.com/chromium/src/+/034ca9381180401b9b25eac088babf7fdae847d8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Patch Set 3 : Split fuzzer for XFA #

Patch Set 4 : Bail early in XFA if non-xfa doc #

Patch Set 5 : Seed corpus #

Patch Set 6 : Rebase to master #

Patch Set 7 : seed corpus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -266 lines) Patch
M pdf/pdfium/fuzzers/BUILD.gn View 1 2 3 4 5 6 3 chunks +23 lines, -0 lines 0 comments Download
M pdf/pdfium/fuzzers/pdfium_fuzzer.cc View 1 2 1 chunk +9 lines, -203 lines 0 comments Download
A pdf/pdfium/fuzzers/pdfium_fuzzer_helper.h View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A + pdf/pdfium/fuzzers/pdfium_fuzzer_helper.cc View 1 2 3 5 chunks +97 lines, -63 lines 0 comments Download
A pdf/pdfium/fuzzers/pdfium_xfa_fuzzer.cc View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (11 generated)
dsinclair
PTAL. mbarbella@ will this work like I want it too? The other fuzzers run in ...
3 years, 9 months ago (2017-03-16 17:42:39 UTC) #2
Tom Sepez
LGTM, but make sure Marty is OK with this too.
3 years, 9 months ago (2017-03-16 17:56:14 UTC) #5
Lei Zhang
https://codereview.chromium.org/2754103002/diff/1/pdf/pdfium/fuzzers/BUILD.gn File pdf/pdfium/fuzzers/BUILD.gn (right): https://codereview.chromium.org/2754103002/diff/1/pdf/pdfium/fuzzers/BUILD.gn#newcode106 pdf/pdfium/fuzzers/BUILD.gn:106: # If XFA is enabled in Chrome, this fuzzer ...
3 years, 9 months ago (2017-03-16 18:52:19 UTC) #6
dsinclair
https://codereview.chromium.org/2754103002/diff/1/pdf/pdfium/fuzzers/BUILD.gn File pdf/pdfium/fuzzers/BUILD.gn (right): https://codereview.chromium.org/2754103002/diff/1/pdf/pdfium/fuzzers/BUILD.gn#newcode106 pdf/pdfium/fuzzers/BUILD.gn:106: # If XFA is enabled in Chrome, this fuzzer ...
3 years, 9 months ago (2017-03-16 20:28:28 UTC) #9
Lei Zhang
lgtm
3 years, 9 months ago (2017-03-16 21:25:40 UTC) #10
dsinclair
Martin, ping.
3 years, 9 months ago (2017-03-21 13:10:04 UTC) #11
Martin Barbella
On 2017/03/21 13:10:04, dsinclair wrote: > Martin, ping. Sorry for the slow reply. Assuming I ...
3 years, 9 months ago (2017-03-21 20:42:07 UTC) #13
dsinclair
On 2017/03/21 20:42:07, Martin Barbella wrote: > On 2017/03/21 13:10:04, dsinclair wrote: > > Martin, ...
3 years, 9 months ago (2017-03-21 20:46:46 UTC) #14
Martin Barbella
On 2017/03/21 20:46:46, dsinclair wrote: > On 2017/03/21 20:42:07, Martin Barbella wrote: > > On ...
3 years, 9 months ago (2017-03-21 22:37:10 UTC) #15
Oliver Chang
On 2017/03/21 22:37:10, Martin Barbella wrote: > On 2017/03/21 20:46:46, dsinclair wrote: > > On ...
3 years, 9 months ago (2017-03-21 22:46:52 UTC) #16
Oliver Chang
On 2017/03/21 22:46:52, Oliver Chang wrote: > On 2017/03/21 22:37:10, Martin Barbella wrote: > > ...
3 years, 9 months ago (2017-03-21 22:48:06 UTC) #17
dsinclair
On 2017/03/21 22:46:52, Oliver Chang wrote: > On 2017/03/21 22:37:10, Martin Barbella wrote: > > ...
3 years, 9 months ago (2017-03-22 00:44:46 UTC) #18
mmoroz
On 2017/03/22 00:44:46, dsinclair wrote: > On 2017/03/21 22:46:52, Oliver Chang wrote: > > On ...
3 years, 9 months ago (2017-03-22 13:34:53 UTC) #19
dsinclair
PTAL. This creates a new fuzzer which will do the LoadXFA call. Do we need ...
3 years, 9 months ago (2017-03-22 15:12:23 UTC) #20
mmoroz
LGTM (though I'm note familiar with pdfium API). Regarding corpus, it doesn't happen automatically, but ...
3 years, 9 months ago (2017-03-22 15:23:30 UTC) #22
dsinclair
On 2017/03/22 15:23:30, mmoroz wrote: > LGTM (though I'm note familiar with pdfium API). > ...
3 years, 9 months ago (2017-03-22 15:24:43 UTC) #23
mmoroz
On 2017/03/22 15:24:43, dsinclair wrote: > On 2017/03/22 15:23:30, mmoroz wrote: > > LGTM (though ...
3 years, 9 months ago (2017-03-22 15:28:20 UTC) #24
dsinclair
On 2017/03/22 15:28:20, mmoroz wrote: > On 2017/03/22 15:24:43, dsinclair wrote: > > On 2017/03/22 ...
3 years, 9 months ago (2017-03-22 15:55:45 UTC) #25
mmoroz
Nice! I believe that we can add it for pdifum_fuzzer as well.
3 years, 9 months ago (2017-03-22 16:55:14 UTC) #26
dsinclair
On 2017/03/22 16:55:14, mmoroz wrote: > Nice! I believe that we can add it for ...
3 years, 9 months ago (2017-03-23 18:43:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754103002/120001
3 years, 9 months ago (2017-03-23 18:44:54 UTC) #30
dsinclair
On 2017/03/23 18:44:54, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 9 months ago (2017-03-23 18:48:09 UTC) #31
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/034ca9381180401b9b25eac088babf7fdae847d8
3 years, 9 months ago (2017-03-23 19:51:50 UTC) #34
mmoroz
On 2017/03/23 18:48:09, dsinclair wrote: > On 2017/03/23 18:44:54, commit-bot: I haz the power wrote: ...
3 years, 8 months ago (2017-03-31 13:24:23 UTC) #35
dsinclair
On 2017/03/31 13:24:23, mmoroz wrote: > On 2017/03/23 18:48:09, dsinclair wrote: > > On 2017/03/23 ...
3 years, 8 months ago (2017-04-03 13:43:28 UTC) #36
mmoroz
3 years, 8 months ago (2017-04-03 15:25:27 UTC) #37
Message was sent while issue was closed.
On 2017/04/03 13:43:28, dsinclair wrote:
> On 2017/03/31 13:24:23, mmoroz wrote:
> > On 2017/03/23 18:48:09, dsinclair wrote:
> > > On 2017/03/23 18:44:54, commit-bot: I haz the power wrote:
> > > > CQ is trying da patch. Follow status at
> > > >  
> > > >
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > > 
> > > 
> > > We have another corpus:
> https://pdfium.googlesource.com/pdfium_tests/+/master
> > > which contains some XFA and other test files. It isn't checked out in
> chrome,
> > > but we could upload those to the folders as well if you wanted more seeds.
> > 
> > Sure, I believe that having more corpus is better. Though an ideal approach
> > would be to verify locally that those files increase the coverage. If they
do,
> > it would be great to have them either in Chromium repo or in
> >
>
https://pantheon.corp.google.com/storage/browser/clusterfuzz-corpus/libfuzzer...
> > and
> >
>
https://pantheon.corp.google.com/storage/browser/clusterfuzz-corpus/libfuzzer...
> > GCS directories.
> 
> 
> Not sure what you mean by the chromium repo? We have them in their own repo so
> as to not increase the size of the pdfium repo. The files can be seen at
> https://pdfium.googlesource.com/pdfium_tests/+/master

By chromium repo I meant: https://chromium.googlesource.com/chromium/chromium/

Unfortunately, we do not have a way to grab seed corpus from any other
repository. Only that one or the GCS bucket.

Powered by Google App Engine
This is Rietveld 408576698