Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2754003007: [compiler] Add even more tests for monotonicity of typing. (Closed)

Created:
3 years, 9 months ago by neis
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Add even more tests for monotonicity of typing. BUG= Review-Url: https://codereview.chromium.org/2754003007 Cr-Commit-Position: refs/heads/master@{#43916} Committed: https://chromium.googlesource.com/v8/v8/+/42487a841099d7fe72d32d0369718c8bcd8fc09f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M test/unittests/compiler/typer-unittest.cc View 4 chunks +54 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
neis
PTAL. I have some thoughts about this stuff, let's talk next week.
3 years, 9 months ago (2017-03-17 15:53:46 UTC) #2
Jarin
lgtm, thanks!
3 years, 9 months ago (2017-03-17 16:14:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754003007/1
3 years, 9 months ago (2017-03-17 18:46:20 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 19:14:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/42487a841099d7fe72d32d0369718c8bcd8...

Powered by Google App Engine
This is Rietveld 408576698