Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2754003004: Remove setting the pointer cursor when the context menu event is sent. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
bokan
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, kinuko+watch, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove setting the pointer cursor when the context menu event is sent. I thought I checked WebFrameWidgetImpl as well but it appears I hadn't. Remove the useless code there as well. WebViewImpl change was originally done in https://chromium.googlesource.com/chromium/src.git/+/7e40fe40d19b2c766df8d860169b11e2cacd9771 BUG=699232 R=bokan@chromium.org Review-Url: https://codereview.chromium.org/2754003004 Cr-Commit-Position: refs/heads/master@{#457629} Committed: https://chromium.googlesource.com/chromium/src/+/05e316e960818110e3c1378c75cedb6372fd2792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dtapuska
3 years, 9 months ago (2017-03-16 19:56:01 UTC) #3
bokan
lgtm
3 years, 9 months ago (2017-03-16 20:12:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754003004/1
3 years, 9 months ago (2017-03-16 20:13:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/410577)
3 years, 9 months ago (2017-03-16 22:33:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754003004/1
3 years, 9 months ago (2017-03-16 23:11:39 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 00:42:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05e316e960818110e3c1378c75ce...

Powered by Google App Engine
This is Rietveld 408576698