build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 2753993002: (Reland) Use logdog butler subcommand to run tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2753993002: (Reland) Use logdog butler subcommand to run tests. (Closed)

Patch Set: address John's comments on logdog filter Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index 1cc82f961405df3dcc7533a7ff1551c743fca76d..9ef75864734ca11c2b43a518b2f65e1d4ab1171d 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -35,6 +35,7 @@ TIMEOUT_ANNOTATIONS = [

('SmallTest', 1 * 60),

]

+LOGCAT_FILTERS = ['*:e', 'chromium:v', 'cr_*:v']

# TODO(jbudorick): Make this private once the instrumentation test_runner is

# deprecated.

@@ -291,7 +292,8 @@ class LocalDeviceInstrumentationTestRun(

time.strftime('%Y%m%dT%H%M%S', time.localtime()),

device.serial)

logmon = logdog_logcat_monitor.LogdogLogcatMonitor(

- device.adb, stream_name)

+ device.adb, stream_name, filter_specs=LOGCAT_FILTERS)

with contextlib_ext.Optional(

logmon, self._test_instance.should_save_logcat):

with contextlib_ext.Optional(

« no previous file with comments | « build/android/pylib/android/logdog_logcat_monitor.py ('k') | build/android/test_runner.py » ('j') | tools/mb/mb.py » ('J')