tools/mb/mb.py - Issue 2753993002: (Reland) Use logdog butler subcommand to run tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb.py

Issue 2753993002: (Reland) Use logdog butler subcommand to run tests. (Closed)

Patch Set: address John's comments on logdog filter Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/mb/mb.py

diff --git a/tools/mb/mb.py b/tools/mb/mb.py

index 917f3c62be301aad351cf8234a38bbb2d46ee84a..734f4f2e33797229690019f10498d0c98fa4bd0a 100755

--- a/tools/mb/mb.py

+++ b/tools/mb/mb.py

@@ -1086,14 +1086,11 @@ class MetaBuildWrapper(object):

output_path=None)

if android and test_type != "script":

- # TODO(crbug.com/693203): Reenable logcat logdog uploading when outage

- # has been resolved.

cmdline = [

- self.PathJoin('bin', 'run_%s' % target),

- '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',

+ '../../build/android/test_wrapper/logdog_wrapper.py',

+ '--target', target,

'--target-devices-file', '${SWARMING_BOT_FILE}',

- '-v'

- ]

+ '--logdog-bin-cmd', '../../bin/logdog_butler']

Dirk Pranke 2017/03/20 23:12:48 is this path right? what directory is that relativ

elif use_xvfb and test_type == 'windowed_test_launcher':

extra_files = [

'../../testing/test_env.py',

« no previous file with comments | « testing/buildbot/chromium.linux.json ('k') | no next file » | no next file with comments »