Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2753983002: MD Settings: change disabled select visuals. (Closed)

Created:
3 years, 9 months ago by scottchen
Modified:
3 years, 9 months ago
Reviewers:
michaelpg, hcarmona
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: change disabled select visuals. The visual we had for disabled md-select was too light for a11y standards; this CL gives it the same visuals as other disabled elements in md-settings. BUG=657647 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2753983002 Cr-Commit-Position: refs/heads/master@{#457522} Committed: https://chromium.googlesource.com/chromium/src/+/ff04fe72fb9f627f2aae234a7893f88f2debbf71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/webui/resources/html/md_select_css.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
scottchen
screenshot for before/after: http://imgur.com/a/oUVgG
3 years, 9 months ago (2017-03-16 01:08:51 UTC) #4
michaelpg
lgtm
3 years, 9 months ago (2017-03-16 01:12:50 UTC) #5
hcarmona
lgtm (I don't think you needed 2 reviewers for this change BTW)
3 years, 9 months ago (2017-03-16 16:45:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753983002/1
3 years, 9 months ago (2017-03-16 17:55:05 UTC) #8
scottchen
On 2017/03/16 16:45:55, hcarmona wrote: > lgtm (I don't think you needed 2 reviewers for ...
3 years, 9 months ago (2017-03-16 17:55:15 UTC) #9
hcarmona
On 2017/03/16 17:55:15, scottchen wrote: > On 2017/03/16 16:45:55, hcarmona wrote: > > lgtm (I ...
3 years, 9 months ago (2017-03-16 17:56:34 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 19:44:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff04fe72fb9f627f2aae234a7893...

Powered by Google App Engine
This is Rietveld 408576698