Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2753973002: Make v8::Eternal::Get and IsEmpty const. (Closed)

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make v8::Eternal::Get and IsEmpty const. They do not modify the state of the handle. Review-Url: https://codereview.chromium.org/2753973002 Cr-Commit-Position: refs/heads/master@{#43907} Committed: https://chromium.googlesource.com/v8/v8/+/3700a01c8243a1f394380e87e479e7db32dc8a14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M include/v8.h View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
WDYT? It's not apparent why these are non-const, so I assume it's an oversight.
3 years, 9 months ago (2017-03-15 23:31:35 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-16 19:12:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753973002/1
3 years, 9 months ago (2017-03-17 14:21:45 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 14:48:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3700a01c8243a1f394380e87e479e7db32d...

Powered by Google App Engine
This is Rietveld 408576698