Refactoring and rewriting the chromoting jni instance to be chromoting session.

remoting/client/ios/bridge/client_instance.h

Index: remoting/client/ios/bridge/client_instance.h
diff --git a/remoting/client/ios/bridge/client_instance.h b/remoting/client/ios/bridge/client_instance.h
index 1ccaccf620dee570e22f980219d9c5dcb380f40e..e769f412f3b80d6ddab7d206dad13213a80cd89c 100644
--- a/remoting/client/ios/bridge/client_instance.h
+++ b/remoting/client/ios/bridge/client_instance.h
@@ -36,11 +36,12 @@ namespace remoting {
 
 // class AudioPlayerIos;
 class ClientProxy;
-class ClientStatusLogger;
+// class ClientStatusLogger;

[Lambros, 2017/04/05 01:31:19]

Remove this instead of commenting out.

[nicholss, 2017/04/05 17:24:26]

Acknowledged, but not going to change this file. The file might be removed next
cl after integration with the current cl is finished. ios/bridge/client_instance
should be replaced with session... Keeping the commented out bits here to
remember what the class looked like to help with integration next.

 class FrameConsumerBridge;
 
-// ClientUserInterface that indirectly makes and receives OBJ_C calls from the
-// UI application.
+// TODO(nicholss): Delete this Class. It needs to use the client version of
+// ClientInstance. ClientUserInterface that indirectly makes and receives OBJ_C

[Lambros, 2017/04/05 01:31:19]

Grammar of final sentence?

[nicholss, 2017/04/05 17:24:26]

Acknowledged. See above.

+// calls from the UI application.
 class ClientInstance : public ClientUserInterface,
                        public protocol::ClipboardStub,
                        public protocol::CursorShapeStub,
@@ -158,7 +159,9 @@ class ClientInstance : public ClientUserInterface,
   std::unique_ptr<ChromotingClient> client_;
   XmppSignalStrategy::XmppServerConfig xmpp_config_;
   std::unique_ptr<XmppSignalStrategy> signaling_;  // Must outlive client_
-  std::unique_ptr<ClientStatusLogger> client_status_logger_;
+
+  // TODO(nicholss): Migrate to ClientTelemetryLogger
+  //  std::unique_ptr<ClientStatusLogger> client_status_logger_;

[Lambros, 2017/04/05 01:31:19]

This is commented out, so remove both lines?

[nicholss, 2017/04/05 17:24:26]

Acknowledged. See above.

 
   // This group of variables is to be used on the audio thread.
   // std::unique_ptr<AudioPlayerIos> audio_player_;