Refactoring and rewriting the chromoting jni instance to be chromoting session.

remoting/client/ios/bridge/client_instance.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_CLIENT_IOS_BRIDGE_CLIENT_INSTANCE_H_
 #define REMOTING_CLIENT_IOS_BRIDGE_CLIENT_INSTANCE_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 18 matching lines @@
 #include "remoting/protocol/performance_tracker.h"
 #include "remoting/protocol/transport_context.h"
 #include "remoting/signaling/xmpp_signal_strategy.h"
 
 //#include "remoting/client/ios/audio_player_ios.h"
 
 namespace remoting {
 
 // class AudioPlayerIos;
 class ClientProxy;
-class ClientStatusLogger;
+// class ClientStatusLogger;

[Lambros, 2017/04/05 01:31:19]

Remove this instead of commenting out.

[nicholss, 2017/04/05 17:24:26]

Acknowledged, but not going to change this file. The file might be removed next
cl after integration with the current cl is finished. ios/bridge/client_instance
should be replaced with session... Keeping the commented out bits here to
remember what the class looked like to help with integration next.

 class FrameConsumerBridge;
 
-// ClientUserInterface that indirectly makes and receives OBJ_C calls from the
-// UI application.
+// TODO(nicholss): Delete this Class. It needs to use the client version of
+// ClientInstance. ClientUserInterface that indirectly makes and receives OBJ_C

[Lambros, 2017/04/05 01:31:19]

Grammar of final sentence?

[nicholss, 2017/04/05 17:24:26]

Acknowledged. See above.

+// calls from the UI application.
 class ClientInstance : public ClientUserInterface,
                        public protocol::ClipboardStub,
                        public protocol::CursorShapeStub,
                        public base::RefCountedThreadSafe<ClientInstance> {
  public:
   // Initiates a connection with the specified host. Call from the UI thread. To
   // connect with an unpaired host, pass in |pairing_id| and |pairing_secret| as
   // empty strings.
   ClientInstance(const base::WeakPtr<ClientProxy>& proxy,
                  const std::string& username,
@@ skipping 97 matching lines @@
   // This group of variables is to be used on the display thread.
   std::unique_ptr<SoftwareVideoRenderer> video_renderer_;
   std::unique_ptr<FrameConsumerBridge> view_;
 
   // This group of variables is to be used on the network thread.
   std::unique_ptr<ClientContext> client_context_;
   std::unique_ptr<protocol::PerformanceTracker> perf_tracker_;
   std::unique_ptr<ChromotingClient> client_;
   XmppSignalStrategy::XmppServerConfig xmpp_config_;
   std::unique_ptr<XmppSignalStrategy> signaling_;  // Must outlive client_
-  std::unique_ptr<ClientStatusLogger> client_status_logger_;
+
+  // TODO(nicholss): Migrate to ClientTelemetryLogger
+  //  std::unique_ptr<ClientStatusLogger> client_status_logger_;

[Lambros, 2017/04/05 01:31:19]

This is commented out, so remove both lines?

[nicholss, 2017/04/05 17:24:26]

Acknowledged. See above.

 
   // This group of variables is to be used on the audio thread.
   // std::unique_ptr<AudioPlayerIos> audio_player_;
 
   // Pass this the user's PIN once we have it. To be assigned and accessed on
   // the UI thread, but must be posted to the network thread to call it.
   protocol::SecretFetchedCallback pin_callback_;
 
   // Indicates whether to establish a new pairing with this host. This is
   // modified in ProvideSecret(), but thereafter to be used only from the
@@ skipping 20 matching lines @@
   scoped_refptr<net::URLRequestContextGetter> url_requester_;
 
   friend class base::RefCountedThreadSafe<ClientInstance>;
 
   DISALLOW_COPY_AND_ASSIGN(ClientInstance);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_IOS_BRIDGE_CLIENT_INSTANCE_H_