Chromium Code Reviews
DescriptionRevert of Un-DCHECK-guard ThreadRestrictionVerifier for strings. (patchset #2 id:20001 of https://codereview.chromium.org/2743663003/ )
Reason for revert:
Reverting as I finish up my investigation.
BUG=701361
Original issue's description:
> Un-DCHECK-guard ThreadRestrictionVerifier for strings.
>
> This should help us debug various String crashes we've been seeing
> through the crash server, particularly the linked bug.
>
> Note that this will definitely make strings slow on Canary, and will
> possibly cause crashes other than the particular one I was looking
> for. These crashes will all be security bugs though, so we should
> get some valuable information regardless.
>
> PSA to blink-dev that I am doing this investigation is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SupcNcaTh_g
>
> This CL should be reverted by 17 March 2017.
> This CL should be reverted by 17 March 2017.
> This CL should be reverted by 17 March 2017.
> This CL should be reverted by 17 March 2017.
>
> BUG=694520
>
> Review-Url: https://codereview.chromium.org/2743663003
> Cr-Commit-Position: refs/heads/master@{#456323}
> Committed: https://chromium.googlesource.com/chromium/src/+/3a001533b29c0fe28f2354285b2c2ac8d57d8ce6
TBR=esprehn@chromium.org,csharrison@chromium.org,sigbjornf@opera.com,wez@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=694520
Review-Url: https://codereview.chromium.org/2753953002
Cr-Commit-Position: refs/heads/master@{#457672}
Committed: https://chromium.googlesource.com/chromium/src/+/32c86f9955aa028ea55a4538c61c67e0dbf6294e
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
|
|||||||||||||||||||||||||||||||||||||