Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2753953002: Revert of Un-DCHECK-guard ThreadRestrictionVerifier for strings. (Closed)

Created:
3 years, 9 months ago by meade_UTC10
Modified:
3 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, Mikhail, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Un-DCHECK-guard ThreadRestrictionVerifier for strings. (patchset #2 id:20001 of https://codereview.chromium.org/2743663003/ ) Reason for revert: Reverting as I finish up my investigation. BUG=701361 Original issue's description: > Un-DCHECK-guard ThreadRestrictionVerifier for strings. > > This should help us debug various String crashes we've been seeing > through the crash server, particularly the linked bug. > > Note that this will definitely make strings slow on Canary, and will > possibly cause crashes other than the particular one I was looking > for. These crashes will all be security bugs though, so we should > get some valuable information regardless. > > PSA to blink-dev that I am doing this investigation is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SupcNcaTh_g > > This CL should be reverted by 17 March 2017. > This CL should be reverted by 17 March 2017. > This CL should be reverted by 17 March 2017. > This CL should be reverted by 17 March 2017. > > BUG=694520 > > Review-Url: https://codereview.chromium.org/2743663003 > Cr-Commit-Position: refs/heads/master@{#456323} > Committed: https://chromium.googlesource.com/chromium/src/+/3a001533b29c0fe28f2354285b2c2ac8d57d8ce6 TBR=esprehn@chromium.org,csharrison@chromium.org,sigbjornf@opera.com,wez@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=694520 Review-Url: https://codereview.chromium.org/2753953002 Cr-Commit-Position: refs/heads/master@{#457672} Committed: https://chromium.googlesource.com/chromium/src/+/32c86f9955aa028ea55a4538c61c67e0dbf6294e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -42 lines) Patch
M third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 4 chunks +15 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
meade_UTC10
Created Revert of Un-DCHECK-guard ThreadRestrictionVerifier for strings.
3 years, 9 months ago (2017-03-15 22:22:51 UTC) #1
Charlie Harrison
LGTM
3 years, 9 months ago (2017-03-15 22:25:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753953002/1
3 years, 9 months ago (2017-03-16 05:51:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/328001)
3 years, 9 months ago (2017-03-16 06:30:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753953002/1
3 years, 9 months ago (2017-03-16 07:15:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/329620)
3 years, 9 months ago (2017-03-16 07:32:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753953002/1
3 years, 9 months ago (2017-03-17 00:26:14 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 03:31:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32c86f9955aa028ea55a4538c61c...

Powered by Google App Engine
This is Rietveld 408576698