Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2753883002: Remove chromeos/chromeos.gyp. (Closed)

Created:
3 years, 9 months ago by teravest
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke, stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, Daniel Erat
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chromeos/chromeos.gyp. This migrates the variables in chromeos.gyp to BUILD.gn, making the source easier to read. This also lets us remove a use of exec_script, so chromeos/BUILD.gn no longer has to be whitelisted to use it. BUG=701617 Review-Url: https://codereview.chromium.org/2753883002 Cr-Commit-Position: refs/heads/master@{#457759} Committed: https://chromium.googlesource.com/chromium/src/+/54ee225d47dd22fe7d2a2cb75bde7d27d790bf49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -512 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/BUILD.gn View 3 chunks +491 lines, -8 lines 0 comments Download
D chromeos/chromeos.gyp View 1 chunk +0 lines, -503 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
teravest
3 years, 9 months ago (2017-03-15 18:50:53 UTC) #4
stevenjb
Thanks! lgtm
3 years, 9 months ago (2017-03-15 19:45:16 UTC) #7
teravest
+dpranke for .gn
3 years, 9 months ago (2017-03-15 21:44:48 UTC) #10
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-15 22:01:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753883002/1
3 years, 9 months ago (2017-03-17 13:16:29 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 14:19:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54ee225d47dd22fe7d2a2cb75bde...

Powered by Google App Engine
This is Rietveld 408576698