Fix race condition in GpuProcess_skip_gpu_process.

Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2753873002
Cr-Commit-Position: refs/heads/master@{#457331}
Committed: https://chromium.googlesource.com/chromium/src/+/a04f321efbf30ec25a5eb8592a549e901ed8ffe7

[Ken Russell (switch to Gerrit), 2017-03-15 18:18:16]

Description was changed from

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
==========

to

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-03-15 18:24:49]

kbr@chromium.org changed reviewers:
+ capn@chromium.org, sugoi@chromium.org

[Ken Russell (switch to Gerrit), 2017-03-15 18:24:50]

PTAL

[Ken Russell (switch to Gerrit), 2017-03-15 18:25:00]

Description was changed from

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-03-15 18:25:28]

Note: I removed android_optional_gpu_tests_rel due to http://crbug.com/701883 .

[Ken Russell (switch to Gerrit), 2017-03-15 18:25:34]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 18:25:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sugoi1, 2017-03-15 18:33:08]

LGTM

[commit-bot: I haz the power, 2017-03-15 20:28:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:28:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2017-03-15 21:11:34]

On 2017/03/15 18:33:08, sugoi1 wrote:
> LGTM

Thanks for your review Alexis. Now that
https://chromium-review.googlesource.com/455464/ has landed, this should pass
the CQ. Trying again.

[Ken Russell (switch to Gerrit), 2017-03-15 21:11:38]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-03-15 21:11:57]

The CQ bit was unchecked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-03-15 21:12:23]

On 2017/03/15 21:11:34, Ken Russell wrote:
> On 2017/03/15 18:33:08, sugoi1 wrote:
> > LGTM
> 
> Thanks for your review Alexis. Now that
> https://chromium-review.googlesource.com/455464/ has landed, this should pass
> the CQ. Trying again.

Whoops, realized that I'll still need to generalize the suppression.

[Ken Russell (switch to Gerrit), 2017-03-15 23:15:59]

Description was changed from

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-03-15 23:17:00]

I'm going to try to include this positive SwiftShader test while making the
other test more robust. CQ'ing now.

[Ken Russell (switch to Gerrit), 2017-03-15 23:17:04]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-03-15 23:17:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sugoi@chromium.org
Link to the patchset: https://codereview.chromium.org/2753873002/#ps20001
(title: "Expanded suppression. Added positive SwiftShader test.")

[commit-bot: I haz the power, 2017-03-15 23:17:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:17:36]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2017-03-16 00:28:13]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-03-16 00:28:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sugoi@chromium.org
Link to the patchset: https://codereview.chromium.org/2753873002/#ps40001
(title: "Fixed breakage in test.")

[commit-bot: I haz the power, 2017-03-16 00:28:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:52:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489624093093000,
"parent_rev": "d381d5a1c5e484072aee0b93b5b89b486f0ab348", "commit_rev":
"a04f321efbf30ec25a5eb8592a549e901ed8ffe7"}

[commit-bot: I haz the power, 2017-03-16 02:52:54]

Description was changed from

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix race condition in GpuProcess_skip_gpu_process.

chrome:gpu may be spinning up a GPU process regardless of
--disable-gpu, causing a race condition. Instead, load a page
containing WebGL content.

This test will not work on platforms where SwiftShader is enabled as a
software fallback. It should be disabled there, and removed once
SwiftShader is deployed everywhere.

BUG=701625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2753873002
Cr-Commit-Position: refs/heads/master@{#457331}
Committed:
https://chromium.googlesource.com/chromium/src/+/a04f321efbf30ec25a5eb8592a54...
==========

[commit-bot: I haz the power, 2017-03-16 02:52:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a04f321efbf30ec25a5eb8592a54...