Clarify Beacon transmission limit checking.

Clarify Beacon transmission limit checking.

The implementation of navigator.sendBeacon() imposes a cap on the size
of transmitted beacon payloads. The internal handling of that limit
was not as clear as could be, so attempt to clarify its representation
and handling.

Also clarify the interpretation of a negative cap limit: if a frame's
settings provide a negative value, no transmission limit is imposed.

R=mkwst, tyoshino
BUG=701678
Review-Url: https://codereview.chromium.org/2753863003
Cr-Commit-Position: refs/heads/master@{#459564}
Committed: https://chromium.googlesource.com/chromium/src/+/095bbad98260feae3a161c19ca1e9d9809dd544b

[sof, 2017-03-16 10:10:30]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 10:10:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 11:53:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 11:53:59]

Dry run: This issue passed the CQ dry run.

[sof, 2017-03-16 12:00:59]

sigbjornf@opera.com changed reviewers:
+ tyoshino@chromium.org

[sof, 2017-03-16 12:01:00]

please take a look.

( i.e., I think we really should keep around the facility to disable this limit.
)

[sof, 2017-03-21 08:41:47]

ping? would be good to send this one along :)

[sof, 2017-03-23 20:50:13]

sigbjornf@opera.com changed reviewers:
+ mkwst@chromium.org

[sof, 2017-03-23 20:50:14]

+mkwst

[tyoshino (SeeGerritForStatus), 2017-03-23 23:40:46]

Sorry! I'll take a look at this today.

[Mike West, 2017-03-24 08:29:08]

LGTM.

[tyoshino (SeeGerritForStatus), 2017-03-24 10:14:38]

lgtm! thanks

[sof, 2017-03-24 15:22:03]

great, thanks both :)

[sof, 2017-03-24 15:22:16]

Description was changed from

==========
Clarify Beacon transmission limit checking.

The implementation of navigator.sendBeacon() imposes a cap on the size
of transmitted beacon payloads. The internal handling of that limit
was not as clear as could be, so attempt to clarify its representation
and handling.

Also clarify the interpretation of a negative cap limit: if a frame's
settings provide a negative value, no transmission limit is imposed.

R=
BUG=701678
==========

to

==========
Clarify Beacon transmission limit checking.

The implementation of navigator.sendBeacon() imposes a cap on the size
of transmitted beacon payloads. The internal handling of that limit
was not as clear as could be, so attempt to clarify its representation
and handling.

Also clarify the interpretation of a negative cap limit: if a frame's
settings provide a negative value, no transmission limit is imposed.

R=mkwst, tyoshino
BUG=701678
==========

[sof, 2017-03-24 15:22:23]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-03-24 15:23:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 15:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 15:26:45]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sof, 2017-03-24 20:15:26]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-03-24 20:15:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2753863003/#ps20001
(title: "rebased upto r459528")

[commit-bot: I haz the power, 2017-03-24 20:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:47:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490386526377530,
"parent_rev": "369b8f475926bbf246b569ffb7d6236b7946f209", "commit_rev":
"095bbad98260feae3a161c19ca1e9d9809dd544b"}

[commit-bot: I haz the power, 2017-03-24 21:48:07]

Description was changed from

==========
Clarify Beacon transmission limit checking.

The implementation of navigator.sendBeacon() imposes a cap on the size
of transmitted beacon payloads. The internal handling of that limit
was not as clear as could be, so attempt to clarify its representation
and handling.

Also clarify the interpretation of a negative cap limit: if a frame's
settings provide a negative value, no transmission limit is imposed.

R=mkwst, tyoshino
BUG=701678
==========

to

==========
Clarify Beacon transmission limit checking.

The implementation of navigator.sendBeacon() imposes a cap on the size
of transmitted beacon payloads. The internal handling of that limit
was not as clear as could be, so attempt to clarify its representation
and handling.

Also clarify the interpretation of a negative cap limit: if a frame's
settings provide a negative value, no transmission limit is imposed.

R=mkwst, tyoshino
BUG=701678

Review-Url: https://codereview.chromium.org/2753863003
Cr-Commit-Position: refs/heads/master@{#459564}
Committed:
https://chromium.googlesource.com/chromium/src/+/095bbad98260feae3a161c19ca1e...
==========

[commit-bot: I haz the power, 2017-03-24 21:48:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/095bbad98260feae3a161c19ca1e...