Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2753753006: cocoa: hide icon in permission bubble from a11y tree (Closed)

Created:
3 years, 9 months ago by Elly Fong-Jones
Modified:
3 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa: hide icon in permission bubble from a11y tree BUG=699774 Review-Url: https://codereview.chromium.org/2753753006 Cr-Commit-Position: refs/heads/master@{#457444} Committed: https://chromium.googlesource.com/chromium/src/+/4c09f9d52e8950f63860599ca566b74369dfa4f4

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Elly Fong-Jones
mark: ptal? :)
3 years, 9 months ago (2017-03-15 19:29:04 UTC) #3
Mark Mentovai
LGTM
3 years, 9 months ago (2017-03-15 19:47:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753753006/1
3 years, 9 months ago (2017-03-16 14:39:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/171686) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-16 14:41:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753753006/20001
3 years, 9 months ago (2017-03-16 15:18:46 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 15:39:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c09f9d52e8950f63860599ca566...

Powered by Google App Engine
This is Rietveld 408576698