Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2753743005: mediaview: Hack to avoid Files app to freeze soon after login. (Closed)

Created:
3 years, 9 months ago by Shuhei Takahashi
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

mediaview: Hack to avoid Files app to freeze soon after login. Files app freezes until storage::WatcherManager::AddWatcher() finishes. To avoid this issue, add a hack to ArcDocumentsProviderRoot so that AddWatcher() pretends to finish immediately. Ideally this issue should be fixed in Files app. However its current design assumes operations on changing the current working directory are serialized. Therefore this change tries to workaround the issue in a quick way. BUG=chromium:698624 TEST=Files app does not freeze soon after login. TEST=unit_tests Review-Url: https://codereview.chromium.org/2726373002 Cr-Commit-Position: refs/heads/master@{#456945} (cherry picked from commit 3f89cb4d2e652514501cd26bcf7fd75f1fda73f8) Review-Url: https://codereview.chromium.org/2753743005 . Cr-Commit-Position: refs/branch-heads/3029@{#227} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7f1b243d17654d56433da28ad4d4e8865f7a3046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -43 lines) Patch
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h View 3 chunks +39 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc View 5 chunks +62 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Shuhei Takahashi
3 years, 9 months ago (2017-03-16 06:08:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f1b243d17654d56433da28ad4d4e8865f7a3046.

Powered by Google App Engine
This is Rietveld 408576698