Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Issue 2753743004: Revive layout test unintentionally removed. (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revive layout test unintentionally removed. We should have removed editing/deleting/password-delete-performance.html not password-delete-contents.html at https://codereview.chromium.org/2730433004/ BUG=698626 Review-Url: https://codereview.chromium.org/2753743004 Cr-Commit-Position: refs/heads/master@{#457355} Committed: https://chromium.googlesource.com/chromium/src/+/807219a299ce1f745a2520a105ff5b2875fc497a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -34 lines) Patch
A third_party/WebKit/LayoutTests/editing/deleting/password-delete-contents.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/deleting/password-delete-contents-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/password-delete-performance.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/password-delete-performance-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yoichio
3 years, 9 months ago (2017-03-16 02:25:34 UTC) #5
yosin_UTC9
lgtm Oops, thanks for recover!
3 years, 9 months ago (2017-03-16 04:28:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753743004/1
3 years, 9 months ago (2017-03-16 05:06:58 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 05:12:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/807219a299ce1f745a2520a105ff...

Powered by Google App Engine
This is Rietveld 408576698