Remove 'global' user-data in favor of 'process' user-data.

Remove 'global' user-data in favor of 'process' user-data.

There's (currently) no cross-process thread safety possible for the ActivityUserData structure so it's not feasible to have a "global" entry.

BUG=620813
Review-Url: https://codereview.chromium.org/2753573002
Cr-Commit-Position: refs/heads/master@{#463663}
Committed: https://chromium.googlesource.com/chromium/src/+/8ffd39048b78f37e10e5bc2cf50f5f338b304e87

[bcwhite, 2017-03-14 18:28:07]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[bcwhite, 2017-03-14 18:28:46]

bcwhite@chromium.org changed reviewers:
+ manzagop@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:28:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 18:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:35:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[manzagop (departed), 2017-03-14 19:32:24]

Nice!

Looks like you're missing a few instances in
postmortem_report_collector_unittest.cc

Could you also expand on the CL description to mention the motivation (user data
currently only supports a single writer).

If we do the transition this way, we'll drop all postmortem reports recorded
with global data but collected with process data (as we'll think they're missing
version details). I think that's fine though.

[bcwhite, 2017-03-16 17:25:05]

Description was changed from

==========
Remove 'global' user-data in favor of 'process' user-data.

BUG=620813
==========

to

==========
Remove 'global' user-data in favor of 'process' user-data.

There's (currently) no cross-process thread safety possible for the
ActivityUserData structure so it's not feasible to have a "global" entry.

BUG=620813
==========

[bcwhite, 2017-03-17 23:19:16]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 23:20:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 01:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:05:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bcwhite, 2017-03-28 20:30:40]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 20:31:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 20:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 20:42:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[bcwhite, 2017-04-10 11:49:16]

Patchset #2 (id:20001) has been deleted

[bcwhite, 2017-04-10 19:08:25]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 19:09:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-04-10 20:54:35]

Patchset #2 (id:40001) has been deleted

[bcwhite, 2017-04-10 20:55:36]

PTAL

> Could you also expand on the CL description to mention the motivation (user
data
> currently only supports a single writer).

Done.  Multiple writers are supported... just not cross-process.


> If we do the transition this way, we'll drop all postmortem reports recorded
> with global data but collected with process data (as we'll think they're
missing
> version details). I think that's fine though.

Ack.

[commit-bot: I haz the power, 2017-04-10 20:58:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 20:58:50]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2017-04-11 13:22:46]

lgtm

We should see a spike of WRITE_TO_MINIDUMP_FAILED because of the missing version
details.

[bcwhite, 2017-04-11 13:39:53]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2017-04-11 13:40:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 13:46:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 13:46:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bcwhite, 2017-04-11 14:05:56]

bcwhite@chromium.org changed reviewers:
+ jwd@chromium.org

[bcwhite, 2017-04-11 14:05:56]

+jwd for
chrome/browser/chrome_browser_field_trials_desktop.cc

[jwd, 2017-04-11 16:39:51]

lgtm

[bcwhite, 2017-04-11 17:02:14]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2017-04-11 17:02:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 17:10:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491930134575370,
"parent_rev": "cd2205139c375696291bffcf86d27ef4e83d7994", "commit_rev":
"8ffd39048b78f37e10e5bc2cf50f5f338b304e87"}

[commit-bot: I haz the power, 2017-04-11 17:11:45]

Description was changed from

==========
Remove 'global' user-data in favor of 'process' user-data.

There's (currently) no cross-process thread safety possible for the
ActivityUserData structure so it's not feasible to have a "global" entry.

BUG=620813
==========

to

==========
Remove 'global' user-data in favor of 'process' user-data.

There's (currently) no cross-process thread safety possible for the
ActivityUserData structure so it's not feasible to have a "global" entry.

BUG=620813

Review-Url: https://codereview.chromium.org/2753573002
Cr-Commit-Position: refs/heads/master@{#463663}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ffd39048b78f37e10e5bc2cf50f...
==========

[commit-bot: I haz the power, 2017-04-11 17:11:46]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8ffd39048b78f37e10e5bc2cf50f...