[profiler] Web UI: add summary of opts/deopts.

[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the function timeline 
now shows optimization and deoptimization marks.

Review-Url: https://codereview.chromium.org/2753543006
Cr-Commit-Position: refs/heads/master@{#44033}
Committed: https://chromium.googlesource.com/v8/v8/+/12d815b36e5d0b79688ba399d25ed1d44e69dd15

[Jarin, 2017-03-20 20:13:23]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-03-20 20:29:16]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:29:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-03-20 20:31:39]

Description was changed from

==========
[profiler] Web UI: add summary of opts/deopts.

WIP.

BUG=
==========

to

==========
[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the
function timeline now shows
optimization and deoptimization marks (but the legend should still be updated).
==========

[Jarin, 2017-03-20 20:31:39]

jarin@chromium.org changed reviewers:
+ leszeks@chromium.org, yangguo@chromium.org

[Jarin, 2017-03-20 20:33:22]

Description was changed from

==========
[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the
function timeline now shows
optimization and deoptimization marks (but the legend should still be updated).
==========

to

==========
[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the
function
timeline 
now shows optimization and deoptimization marks.
==========

[Jarin, 2017-03-20 20:33:40]

Description was changed from

==========
[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the
function
timeline 
now shows optimization and deoptimization marks.
==========

to

==========
[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the
function timeline 
now shows optimization and deoptimization marks.
==========

[Jarin, 2017-03-20 20:34:02]

Could you take a look, please?

[commit-bot: I haz the power, 2017-03-20 20:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:53:21]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-21 14:22:29]

On 2017/03/20 20:34:02, Jarin wrote:
> Could you take a look, please?

V8 part lgtm. Not familiar with the JS part, happy to just rubberstamp though.

[Leszek Swirski, 2017-03-21 14:28:39]

lgtm with nits.

https://codereview.chromium.org/2753543006/diff/140001/src/code-events.h
File src/code-events.h (right):

https://codereview.chromium.org/2753543006/diff/140001/src/code-events.h#newc...
src/code-events.h:109: virtual void CodeDeoptEvent(DeoptKind kind, Code* code,
Address pc,
nit: it would be neater if the Code was the first parameter, for consistency
with the other methods.

https://codereview.chromium.org/2753543006/diff/140001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/2753543006/diff/140001/src/deoptimizer.cc#new...
src/deoptimizer.cc:513: switch (type) {
extract to method

https://codereview.chromium.org/2753543006/diff/140001/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/2753543006/diff/140001/src/log.cc#newcode1053
src/log.cc:1053: int timestamp = timer->IsStarted()
nit: inconsistent use of if blocks vs. ternary operator -- either is fine with
me

https://codereview.chromium.org/2753543006/diff/140001/tools/profile.js
File tools/profile.js (right):

https://codereview.chromium.org/2753543006/diff/140001/tools/profile.js#newco...
tools/profile.js:138: type, name, timestamp,  start, size) {
nit: too many spaces before "start"

https://codereview.chromium.org/2753543006/diff/140001/tools/profview/profvie...
File tools/profview/profview.js (right):

https://codereview.chromium.org/2753543006/diff/140001/tools/profview/profvie...
tools/profview/profview.js:941: ctx.moveTo(x - 3, y - 3);
maybe we should extract out a "draw line" method, and a "draw
optimization/deoptimization mark" method that uses it. I'm happy for that to be
a followup cleanup CL though.

[Jarin, 2017-03-22 15:31:59]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 15:32:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-03-22 15:47:30]

The CQ bit was unchecked by jarin@chromium.org

[Jarin, 2017-03-22 15:47:31]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2017-03-22 15:47:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, leszeks@chromium.org
Link to the patchset: https://codereview.chromium.org/2753543006/#ps200001
(title: "Address reviewer comments")

[commit-bot: I haz the power, 2017-03-22 15:47:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 16:02:25]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1490197651092710,
"parent_rev": "2ff2a0c65d07bed1b8de3d77dce2e1848574e3d2", "commit_rev":
"12d815b36e5d0b79688ba399d25ed1d44e69dd15"}

[commit-bot: I haz the power, 2017-03-22 16:02:31]

Description was changed from

==========
[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the
function timeline 
now shows optimization and deoptimization marks.
==========

to

==========
[profiler] Web UI: add summary of opts/deopts.

This adds optimization and deoptimization counts to the Web UI. Also, the
function timeline 
now shows optimization and deoptimization marks.

Review-Url: https://codereview.chromium.org/2753543006
Cr-Commit-Position: refs/heads/master@{#44033}
Committed:
https://chromium.googlesource.com/v8/v8/+/12d815b36e5d0b79688ba399d25ed1d44e6...
==========

[commit-bot: I haz the power, 2017-03-22 16:02:32]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/v8/v8/+/12d815b36e5d0b79688ba399d25ed1d44e6...