Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2753543004: DevTools: CharacterIdMap should be able to return empty string (Closed)

Created:
3 years, 9 months ago by einbinder
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: CharacterIdMap should be able to return empty string CharacterIdMap is used for strings, but if the empty string was stored it would return null. BUG=610061 Review-Url: https://codereview.chromium.org/2753543004 Cr-Commit-Position: refs/heads/master@{#456936} Committed: https://chromium.googlesource.com/chromium/src/+/3bddfe5d8dd5ca4f1431cbef44d3bbaf4dced3e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/common/CharacterIdMap.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
einbinder
ptal
3 years, 9 months ago (2017-03-14 21:04:53 UTC) #3
lushnikov
lgtm
3 years, 9 months ago (2017-03-14 21:46:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753543004/1
3 years, 9 months ago (2017-03-15 01:16:54 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 01:23:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bddfe5d8dd5ca4f1431cbef44d3...

Powered by Google App Engine
This is Rietveld 408576698