Fixed a bug in TouchActionFilter for unidirectional touch-actions.

Fixed a bug in TouchActionFilter for unidirectional touch-actions.

This CL simplifies the touch-action filtering code and fixes a crack
introduced through unidirectional touch action support. Touch-actions
left/right/up/down should never allow opposite exact diagonal swipes
even though still allowing diagonals towards the touch-action direction
as before.

BUG=697102
Review-Url: https://codereview.chromium.org/2753533002
Cr-Commit-Position: refs/heads/master@{#457133}
Committed: https://chromium.googlesource.com/chromium/src/+/4d73d6ea6360a1a74625a2f9ac3a0eab8ef3cfb2

[mustaq, 2017-03-14 16:51:36]

mustaq@chromium.org changed reviewers:
+ dtapuska@chromium.org, rbyers@chromium.org

[mustaq, 2017-03-14 16:51:36]

ptal

[dtapuska, 2017-03-14 17:28:32]

https://codereview.chromium.org/2753533002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_action_filter.cc (right):

https://codereview.chromium.org/2753533002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_action_filter.cc:196: if
(fabs(deltaXHint) <= fabs(deltaYHint)) {
Can we write this as fabs(deltaYHint) >= fabs(deltaXHint)  and maybe store
fabs(...) on the stack?

[mustaq, 2017-03-14 20:05:38]

https://codereview.chromium.org/2753533002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_action_filter.cc (right):

https://codereview.chromium.org/2753533002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_action_filter.cc:196: if
(fabs(deltaXHint) <= fabs(deltaYHint)) {
On 2017/03/14 17:28:32, dtapuska wrote:
> Can we write this as fabs(deltaYHint) >= fabs(deltaXHint)  and maybe store
> fabs(...) on the stack?

Done.

[mustaq, 2017-03-14 20:16:35]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 20:17:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-03-14 20:21:17]

On 2017/03/14 20:05:38, mustaq wrote:
>
https://codereview.chromium.org/2753533002/diff/1/content/browser/renderer_ho...
> File content/browser/renderer_host/input/touch_action_filter.cc (right):
> 
>
https://codereview.chromium.org/2753533002/diff/1/content/browser/renderer_ho...
> content/browser/renderer_host/input/touch_action_filter.cc:196: if
> (fabs(deltaXHint) <= fabs(deltaYHint)) {
> On 2017/03/14 17:28:32, dtapuska wrote:
> > Can we write this as fabs(deltaYHint) >= fabs(deltaXHint)  and maybe store
> > fabs(...) on the stack?
> 
> Done.

lgtm

[commit-bot: I haz the power, 2017-03-14 20:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:50:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mustaq, 2017-03-15 15:58:04]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2017-03-15 15:58:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2753533002/#ps60001
(title: "Fixed a test.")

[commit-bot: I haz the power, 2017-03-15 15:58:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2017-03-15 15:59:06]

The CQ bit was unchecked by mustaq@chromium.org

[mustaq, 2017-03-15 16:02:10]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2017-03-15 16:02:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2753533002/#ps80001
(title: "Fixed a test.")

[commit-bot: I haz the power, 2017-03-15 16:02:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 16:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 16:41:17]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mustaq, 2017-03-15 16:57:05]

The CQ bit was checked by mustaq@chromium.org

[commit-bot: I haz the power, 2017-03-15 16:57:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 17:54:44]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489597025589160,
"parent_rev": "78ba5153e9c3d6f9cc38785e9982f7bc153b5cd7", "commit_rev":
"4d73d6ea6360a1a74625a2f9ac3a0eab8ef3cfb2"}

[commit-bot: I haz the power, 2017-03-15 17:55:22]

Description was changed from

==========
Fixed a bug in TouchActionFilter for unidirectional touch-actions.

This CL simplifies the touch-action filtering code and fixes a crack
introduced through unidirectional touch action support. Touch-actions
left/right/up/down should never allow opposite exact diagonal swipes
even though still allowing diagonals towards the touch-action direction
as before.

BUG=697102
==========

to

==========
Fixed a bug in TouchActionFilter for unidirectional touch-actions.

This CL simplifies the touch-action filtering code and fixes a crack
introduced through unidirectional touch action support. Touch-actions
left/right/up/down should never allow opposite exact diagonal swipes
even though still allowing diagonals towards the touch-action direction
as before.

BUG=697102

Review-Url: https://codereview.chromium.org/2753533002
Cr-Commit-Position: refs/heads/master@{#457133}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d73d6ea6360a1a74625a2f9ac3a...
==========

[commit-bot: I haz the power, 2017-03-15 17:55:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4d73d6ea6360a1a74625a2f9ac3a...