Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2753513007: Image Capture: clarify idl flags (Closed)

Created:
3 years, 9 months ago by mcasas
Modified:
3 years, 9 months ago
Reviewers:
tkent, Guido Urdaneta
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, haraken, jam, mcasas+imagecapture_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, tommyw+watchlist_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: clarify idl flags This CL adds a MediaTrackCapabilities flag and makes MediaTrackCapabilities.idl and MediaStreamTrack.getCapabilities() depend on it. It's implied_by ImageCapture since the latter needs it. Also reshuffled one other flag to match alphabetical order. BUG=700607 Review-Url: https://codereview.chromium.org/2753513007 Cr-Commit-Position: refs/heads/master@{#457267} Committed: https://chromium.googlesource.com/chromium/src/+/f0b3c0982895cc340125f558b0f978c53e7543f2

Patch Set 1 : #

Patch Set 2 : Exception: Dictionary cannot be RuntimeEnabled: MediaTrackCapabilities #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
mcasas
guidou@ ptal tkent@ RS plz the changes in runtime enabled flags file.
3 years, 9 months ago (2017-03-15 19:24:01 UTC) #8
Guido Urdaneta
mediastream lgtm
3 years, 9 months ago (2017-03-15 19:40:55 UTC) #11
tkent
lgtm
3 years, 9 months ago (2017-03-15 22:47:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753513007/60001
3 years, 9 months ago (2017-03-15 23:19:08 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 23:52:19 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f0b3c0982895cc340125f558b0f9...

Powered by Google App Engine
This is Rietveld 408576698