Followup Feedback on https://codereview.chromium.org/2726073002/

Followup Feedback on https://codereview.chromium.org/2726073002/

BUG=684080
Review-Url: https://codereview.chromium.org/2753443005
Cr-Commit-Position: refs/heads/master@{#457486}
Committed: https://chromium.googlesource.com/chromium/src/+/1bffa9cec8d71756a35cc92c1d753574c26b6f07

[robliao, 2017-03-15 20:39:48]

robliao@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2017-03-15 20:45:12]

lgtm % question

https://codereview.chromium.org/2753443005/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
(right):

https://codereview.chromium.org/2753443005/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc:349:
EXPECT_TRUE(task_runner->PostTask(FROM_HERE, Bind(&DoNothing)));
Then wouldn't you want to bind something here that makes sure it's deleted (i.e.
that task was freed)?

[robliao, 2017-03-15 20:49:30]

https://codereview.chromium.org/2753443005/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
(right):

https://codereview.chromium.org/2753443005/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc:349:
EXPECT_TRUE(task_runner->PostTask(FROM_HERE, Bind(&DoNothing)));
On 2017/03/15 20:45:12, gab wrote:
> Then wouldn't you want to bind something here that makes sure it's deleted
(i.e.
> that task was freed)?

If the task isn't deleted, the SingleThreadTaskRunner remains alive and we'll
assert later on. Adding machinery to replicate this loop seemed unnecessary.

[robliao, 2017-03-15 20:49:36]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:50:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 22:00:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 22:00:06]

Dry run: This issue passed the CQ dry run.

[gab, 2017-03-16 17:46:03]

On 2017/03/15 20:49:30, robliao wrote:
>
https://codereview.chromium.org/2753443005/diff/1/base/task_scheduler/schedul...
> File
base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/2753443005/diff/1/base/task_scheduler/schedul...
>
base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc:349:
> EXPECT_TRUE(task_runner->PostTask(FROM_HERE, Bind(&DoNothing)));
> On 2017/03/15 20:45:12, gab wrote:
> > Then wouldn't you want to bind something here that makes sure it's deleted
> (i.e.
> > that task was freed)?
> 
> If the task isn't deleted, the SingleThreadTaskRunner remains alive and we'll
> assert later on. Adding machinery to replicate this loop seemed unnecessary.

Ok hadn't realized it was verified already LGTM

[robliao, 2017-03-16 17:46:33]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:47:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:54:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489686393727670, "parent_rev":
"0611c94f01981658a9c0b6327d3195ad4a129d75", "commit_rev":
"1bffa9cec8d71756a35cc92c1d753574c26b6f07"}

[commit-bot: I haz the power, 2017-03-16 17:55:14]

Description was changed from

==========
Followup Feedback on https://codereview.chromium.org/2726073002/

BUG=684080
==========

to

==========
Followup Feedback on https://codereview.chromium.org/2726073002/

BUG=684080

Review-Url: https://codereview.chromium.org/2753443005
Cr-Commit-Position: refs/heads/master@{#457486}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bffa9cec8d71756a35cc92c1d75...
==========

[commit-bot: I haz the power, 2017-03-16 17:55:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bffa9cec8d71756a35cc92c1d75...