Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/resources/settings/device_page/pointers.js

Issue 2753353002: MD Settings: Pointers: Avoid setting mouse swap pref while mouse pressed (Closed)
Patch Set: Elim console.log Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/device_page/pointers.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/device_page/pointers.js
diff --git a/chrome/browser/resources/settings/device_page/pointers.js b/chrome/browser/resources/settings/device_page/pointers.js
index daca5be59250c064aa09a899151c630e6de1e4f3..6219906a8e610be0d4c3712224bddadf0af42870 100644
--- a/chrome/browser/resources/settings/device_page/pointers.js
+++ b/chrome/browser/resources/settings/device_page/pointers.js
@@ -32,6 +32,10 @@ Polymer({
},
},
+ // Used to correctly identify when the mouse button has been released.
+ // crbug.com/686949.
+ receivedMouseSwapButtonsDown_: false,
+
/**
* Prevents the link from activating its parent paper-radio-button.
* @param {!Event} e
@@ -46,8 +50,29 @@ Polymer({
* @param {boolean} hasMouse
* @param {boolean} hasTouchpad
* @return {string}
+ * @private
*/
getSubsectionClass_: function(hasMouse, hasTouchpad) {
return hasMouse && hasTouchpad ? 'subsection' : '';
},
+
+ /** @private */
+ onMouseSwapButtonsDown_: function() {
+ this.receivedMouseSwapButtonsDown_ = true;
+ },
+
+ /** @private */
+ onMouseSwapButtonsUp_: function() {
+ this.receivedMouseSwapButtonsDown_ = false;
+ /** @type {!SettingsToggleButtonElement} */ (this.$.mouseSwapButton)
+ .sendPrefChange();
+ },
+
+ /** @private */
+ onMouseSwapButtonsChange_: function(event) {
+ if (!this.receivedMouseSwapButtonsDown_) {
+ /** @type {!SettingsToggleButtonElement} */ (this.$.mouseSwapButton)
+ .sendPrefChange();
+ }
+ },
});
« no previous file with comments | « chrome/browser/resources/settings/device_page/pointers.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698