Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/browser/resources/settings/device_page/pointers.html

Issue 2753353002: MD Settings: Pointers: Avoid setting mouse swap pref while mouse pressed (Closed)
Patch Set: Elim console.log Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/pointers.html
diff --git a/chrome/browser/resources/settings/device_page/pointers.html b/chrome/browser/resources/settings/device_page/pointers.html
index fd94a40c81aaa9c0d600f387e39c71395fe21c8f..6c7eaa1026f001b3fc7e782f652df978f9d3174a 100644
--- a/chrome/browser/resources/settings/device_page/pointers.html
+++ b/chrome/browser/resources/settings/device_page/pointers.html
@@ -29,9 +29,14 @@
<!-- Subsection title only appears if both mouse and touchpad exist. -->
<h2 hidden$="[[!hasTouchpad]]">$i18n{mouseTitle}</h2>
<div class="settings-box first">
- <settings-toggle-button class="start"
+ <!-- Do not change the mouse button pref before the mouse is released.
+ See crbug.com/686949 -->
+ <settings-toggle-button id="mouseSwapButton" class="start"
pref="{{prefs.settings.mouse.primary_right}}"
- label="$i18n{mouseSwapButtons}">
+ label="$i18n{mouseSwapButtons}"
+ on-settings-boolean-control-change="onMouseSwapButtonsChange_"
+ on-down="onMouseSwapButtonsDown_" on-up="onMouseSwapButtonsUp_"
+ no-set-pref>
</settings-toggle-button>
</div>
<div class="settings-box">

Powered by Google App Engine
This is Rietveld 408576698