Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2753333002:
Enable NV12 HW overlays. (Closed)
|
Created:
3 years, 9 months ago by Daniele Castagna Modified:
3 years, 9 months ago Reviewers:
reveman CC:
cc-bugs_chromium.org, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable NV12 HW overlays.
This patch enables NV12 (gfx::BufferFormat::YUV_420_BIPLANAR) hardware
overlays where possible.
Additionally, it adds gfx::BufferFormat::YUV_420_BIPLANAR as a format to
be marked as overlay candidate in exo.
BUG=702750
TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_yuv_client --size=600x400 --use-drm=rockchip --scale=2 --fullscreen
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2753333002
Cr-Commit-Position: refs/heads/master@{#458634}
Committed: https://chromium.googlesource.com/chromium/src/+/a0f637af5fb75e1fbd58e4c4c03807c3e77fa213
Patch Set 1 #Patch Set 2 : Rebase. #
Depends on Patchset: Messages
Total messages: 23 (19 generated)
Description was changed from ========== Enable NV12 HW overlays. This patch enables NV12 (gfx::BufferFormat::YUV_420_BIPLANAR) hardware overlays where possible. Additionally, it adds gfx::BufferFormat::YUV_420_BIPLANAR as a format to be marked as overlay candidate in exo. BUG=702750 TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_yuv_client --size=600x400 --use-drm=rockchip --scale=2 --fullscreen ========== to ========== Enable NV12 HW overlays. This patch enables NV12 (gfx::BufferFormat::YUV_420_BIPLANAR) hardware overlays where possible. Additionally, it adds gfx::BufferFormat::YUV_420_BIPLANAR as a format to be marked as overlay candidate in exo. BUG=702750 TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_yuv_client --size=600x400 --use-drm=rockchip --scale=2 --fullscreen CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
dcastagna@chromium.org changed reviewers: + reveman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
reveman@chromium.org changed reviewers: + reveman@chromium.org
lgtm
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dcastagna@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org Link to the patchset: https://codereview.chromium.org/2753333002/#ps20001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490157495001430,
"parent_rev": "999698bd4862a5ef634b7f8aa45039038b76e87f", "commit_rev":
"a0f637af5fb75e1fbd58e4c4c03807c3e77fa213"}
Message was sent while issue was closed.
Description was changed from ========== Enable NV12 HW overlays. This patch enables NV12 (gfx::BufferFormat::YUV_420_BIPLANAR) hardware overlays where possible. Additionally, it adds gfx::BufferFormat::YUV_420_BIPLANAR as a format to be marked as overlay candidate in exo. BUG=702750 TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_yuv_client --size=600x400 --use-drm=rockchip --scale=2 --fullscreen CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Enable NV12 HW overlays. This patch enables NV12 (gfx::BufferFormat::YUV_420_BIPLANAR) hardware overlays where possible. Additionally, it adds gfx::BufferFormat::YUV_420_BIPLANAR as a format to be marked as overlay candidate in exo. BUG=702750 TEST=XDG_RUNTIME_DIR=/var/run/chrome /tmp/wayland_yuv_client --size=600x400 --use-drm=rockchip --scale=2 --fullscreen CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2753333002 Cr-Commit-Position: refs/heads/master@{#458634} Committed: https://chromium.googlesource.com/chromium/src/+/a0f637af5fb75e1fbd58e4c4c038... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a0f637af5fb75e1fbd58e4c4c038... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
