Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2753303002: Add screen tap WebVR tests (Closed)

Created:
3 years, 9 months ago by bsheedy
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add screen tap WebVR tests Adds two new WebVR e2e tests verifying that screen taps are registered in VR when using Cardboard but not Daydream View. Also increases the timeout of certain Javascript executions since 50 ms was sometimes (although rarely) causing flakiness. Re-names the VR restrictions to more clearly differentiate between restrictions on Daydream-readiness and restrictions on the currently paired viewer. BUG=702700 Review-Url: https://codereview.chromium.org/2753303002 Cr-Commit-Position: refs/heads/master@{#458195} Committed: https://chromium.googlesource.com/chromium/src/+/43e217685e5c263404a0b71eadd5f3a30ff59ccf

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
bsheedy
+dtrainor for OWNERS
3 years, 9 months ago (2017-03-17 17:59:40 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-03-20 20:11:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753303002/1
3 years, 9 months ago (2017-03-20 20:13:08 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 21:35:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43e217685e5c263404a0b71eadd5...

Powered by Google App Engine
This is Rietveld 408576698