ARM Skia NEON patches - 33 - Convolution filter

ARM Skia NEON patches - 33 - Convolution filter
NEON version of the convolutionProcs

The bitmap_scale benchmark is now twice as fast on ARM.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>;

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12154

Committed: http://code.google.com/p/skia/source/detail?r=12166

[kevin.petit.not.used.account, 2013-10-16 16:54:17]

This patch implements a NEON version of the convolutionProcs. It has no
mismatches. The code is based on the SSE version.

[djsollen, 2013-10-18 19:02:57]

there are some places where you go over the 100 character limit.  Other than
that nit, I'm fine with taking the patch if it passes GM.

[kevin.petit.not.used.account, 2013-10-21 11:53:57]

Patch Set 2 respects the 100 characters limit. It also fixes existing code in
src/opts/SkBitmapProcState_opts_arm.cpp.

[humper, 2013-10-23 13:43:50]

On 2013/10/21 11:53:57, kevin.petit.arm wrote:
> Patch Set 2 respects the 100 characters limit. It also fixes existing code in
> src/opts/SkBitmapProcState_opts_arm.cpp.

lgtm, thanks

[commit-bot: I haz the power, 2013-10-23 14:49:31]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[kevin.petit.not.used.account, 2013-11-06 13:30:04]

May someone with full commit rights consider giving his lgtm? Thanks.

[djsollen, 2013-11-06 13:56:36]

lgtm

[commit-bot: I haz the power, 2013-11-06 14:20:53]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/27533004/24001

[kevin.petit.not.used.account, 2013-11-06 15:01:06]

Thanks.

[commit-bot: I haz the power, 2013-11-06 15:02:49]

Change committed as 12154

[epoger, 2013-11-06 15:46:26]

I am reverting this CL due to
https://code.google.com/p/skia/issues/detail?id=1807 ('ARM builds broken by
https://skia.googlesource.com/skia.git/+/51fb90055760d64d92c35679e5cdda66e5cd...)

[kevin.petit.not.used.account, 2013-11-06 18:01:35]

This is fixed in Patch Set 3.

Old versions of gyp don't seem to support the definitions that make
skia_warnings_as_errors work.

Could someone reopen the issue so I can add this to the CQ, please?

[epoger, 2013-11-06 18:17:35]

On 2013/11/06 18:01:35, kevin.petit.arm wrote:
> This is fixed in Patch Set 3.
> 
> Old versions of gyp don't seem to support the definitions that make
> skia_warnings_as_errors work.
> 
> Could someone reopen the issue so I can add this to the CQ, please?

Given that you (kevin.petit.arm@gmail.com) created the issue, I think you should
be able to reopen it.  (Click on Edit Issue to find the option)

At any rate, I will reopen the issue... but note that the commit queue won't be
able to commit the CL until the end of the day... the Skia tree is closed today
for maintenance.

[kevin.petit.not.used.account, 2013-11-06 21:20:33]

On 2013/11/06 18:17:35, epoger wrote:
> Given that you (mailto:kevin.petit.arm@gmail.com) created the issue, I think
you should
> be able to reopen it.  (Click on Edit Issue to find the option)

How could I have missed that for so long! I've hassled people many times for
this :-). Thanks a lot.

> At any rate, I will reopen the issue... but note that the commit queue won't
be
> able to commit the CL until the end of the day... the Skia tree is closed
today
> for maintenance.

There's nothing urgent here. I'll put it in the queue and it will be merged ...
when it is merged.

[commit-bot: I haz the power, 2013-11-06 21:20:44]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/27533004/19...

[epoger, 2013-11-07 03:36:16]

On 2013/11/06 21:20:44, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>
https://skia-tree-status.appspot.com/cq/kevin.petit.arm%40gmail.com/27533004/...

I have unchecked the commit box due to
https://code.google.com/p/skia/issues/detail?id=1810 ('a bunch of identical try
jobs have been run on Build-Ubuntu12-GCC-x86_64-Release-Trybot') .

The Skia buildbots and commitqueue are in a fragile state due to maintenance
earlier today; please coordinate with me before attempting to commit this
change.

Sorry for the delay.

[epoger, 2013-11-07 15:37:47]

On 2013/11/07 03:36:16, epoger wrote:
> I have unchecked the commit box due to
> https://code.google.com/p/skia/issues/detail?id=1810 ('a bunch of identical
try
> jobs have been run on Build-Ubuntu12-GCC-x86_64-Release-Trybot') .

Re-checking the commit box, as per
https://code.google.com/p/skia/issues/detail?id=1810#c10

[commit-bot: I haz the power, 2013-11-07 15:37:55]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/27533004/19...

[commit-bot: I haz the power, 2013-11-07 15:57:36]

Change committed as 12166

[kevin.petit.not.used.account, 2013-11-07 15:58:15]

On 2013/11/07 15:37:47, epoger wrote:
> Re-checking the commit box, as per
> https://code.google.com/p/skia/issues/detail?id=1810#c10

Thanks.