Enabling SSL for search engines that now support it

Enabling SSL for search engines that now support it

BUG=624794
R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2753293002
Cr-Commit-Position: refs/heads/master@{#458299}
Committed: https://chromium.googlesource.com/chromium/src/+/6e67d600e764d643cc215c38f465ecf6b89e9406

[Peter Kasting, 2017-03-18 01:03:54]

https://codereview.chromium.org/2753293002/diff/1/components/search_engines/p...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/2753293002/diff/1/components/search_engines/p...
components/search_engines/prepopulated_engines.json:683: "search_url":
"https://search.avg.com/search?q={searchTerms}",
For all the engines from here down, we ship the engine just to monitor
extensions that try to set user preferences to it (since these have showed up in
malicious cases).

I would probably not change the default favicon/search/suggest URLs for these
unless those engines redirect to them and/or ship an OSDD that specifies them. 
(AVG, for example, does neither.)  Instead, I would just add the https search
URLs to the existing HTTP URLs in the "alternate_urls" list.

For any cases where you do change the defaults, I'd add the old HTTP URLs to the
alternates list.

[yakovsh, 2017-03-21 02:10:38]

https://codereview.chromium.org/2753293002/diff/1/components/search_engines/p...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/2753293002/diff/1/components/search_engines/p...
components/search_engines/prepopulated_engines.json:683: "search_url":
"https://search.avg.com/search?q={searchTerms}",
On 2017/03/18 01:03:54, Peter Kasting wrote:
> For all the engines from here down, we ship the engine just to monitor
> extensions that try to set user preferences to it (since these have showed up
in
> malicious cases).
> 
> I would probably not change the default favicon/search/suggest URLs for these
> unless those engines redirect to them and/or ship an OSDD that specifies them.

> (AVG, for example, does neither.)  Instead, I would just add the https search
> URLs to the existing HTTP URLs in the "alternate_urls" list.
> 
> For any cases where you do change the defaults, I'd add the old HTTP URLs to
the
> alternates list.

I updated these accordingly. 

For Rambler and search.goo.net.jp, the OSD document changed and I updated based
on the OSD. For all others, I added HTTPS URLS as alternates.

[Peter Kasting, 2017-03-21 02:12:36]

LGTM

[yakovsh, 2017-03-21 02:21:11]

The CQ bit was checked by yakov@impossibledreams.net

[commit-bot: I haz the power, 2017-03-21 02:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 03:41:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490062871102280,
"parent_rev": "76b0ab1bd832641b00dcd88130ea398bfe0a3a36", "commit_rev":
"6e67d600e764d643cc215c38f465ecf6b89e9406"}

[commit-bot: I haz the power, 2017-03-21 03:42:12]

Description was changed from

==========
Enabling SSL for search engines that now support it

BUG=624794
R=pkasting@chromium.org
==========

to

==========
Enabling SSL for search engines that now support it

BUG=624794
R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2753293002
Cr-Commit-Position: refs/heads/master@{#458299}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e67d600e764d643cc215c38f465...
==========

[commit-bot: I haz the power, 2017-03-21 03:42:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6e67d600e764d643cc215c38f465...