Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2753273002: 📱 Add enable_chrome_android_internal GN flag (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add enable_chrome_android_internal GN flag This flag will allow devs having access to the internal Chrome for Android repo to choose whether to use it in their builds. BUG=702323 Review-Url: https://codereview.chromium.org/2753273002 Cr-Commit-Position: refs/heads/master@{#457749} Committed: https://chromium.googlesource.com/chromium/src/+/d1e190d78a2084aa849819a8921d76e8dfe67e19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dgn
Much easier to implement than I would have expected! Thanks for the pointers. PTAL
3 years, 9 months ago (2017-03-17 11:52:46 UTC) #5
agrieve
On 2017/03/17 11:52:46, dgn wrote: > Much easier to implement than I would have expected! ...
3 years, 9 months ago (2017-03-17 12:54:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753273002/1
3 years, 9 months ago (2017-03-17 13:30:38 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 13:35:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1e190d78a2084aa849819a8921d...

Powered by Google App Engine
This is Rietveld 408576698