Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2753223002: cleanup: Replace NULL with nullptr in network_portal_detector_impl_unittest.cc (Closed)

Created:
3 years, 9 months ago by Qiang(Joe) Xu
Modified:
3 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cleanup: Replace NULL with nullptr in network_portal_detector_impl_unittest.cc Changes: (1) s/NULL/nullptr/g (2) git cl format; just a cleanup, do not want it included in issue 2756643002 BUG=NONE TEST=NONE Review-Url: https://codereview.chromium.org/2753223002 Cr-Commit-Position: refs/heads/master@{#457798} Committed: https://chromium.googlesource.com/chromium/src/+/1eee5dd3db1ad90ec37492e41042c04e44b64cc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc View 25 chunks +35 lines, -35 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Qiang(Joe) Xu
3 years, 9 months ago (2017-03-17 05:44:07 UTC) #7
stevenjb
This is fine, but in the future I wouldn't make a change like this by ...
3 years, 9 months ago (2017-03-17 16:45:34 UTC) #10
Qiang(Joe) Xu
On 2017/03/17 16:45:34, stevenjb wrote: > This is fine, but in the future I wouldn't ...
3 years, 9 months ago (2017-03-17 16:48:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753223002/1
3 years, 9 months ago (2017-03-17 16:49:07 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 16:55:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1eee5dd3db1ad90ec37492e41042...

Powered by Google App Engine
This is Rietveld 408576698