Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2753183002: DevTools: migrate remaining parse html probe to probes. (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate remaining parse html probe to probes. BUG=695625 Review-Url: https://codereview.chromium.org/2753183002 Cr-Commit-Position: refs/heads/master@{#458180} Committed: https://chromium.googlesource.com/chromium/src/+/d1cb28855c8d2d3413fda1655bd71bf7e7cc16b3

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -37 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 3 chunks +21 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pfeldman
3 years, 9 months ago (2017-03-17 01:56:20 UTC) #2
alph
lgtm https://codereview.chromium.org/2753183002/diff/1/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp (right): https://codereview.chromium.org/2753183002/diff/1/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp#newcode54 third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp:54: std::unique_ptr<TracedValue> InspectorParseHtmlBeginData(Document* document, lowercase https://codereview.chromium.org/2753183002/diff/1/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp#newcode64 third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp:64: std::unique_ptr<TracedValue> InspectorParseHtmlEndData(unsigned ...
3 years, 9 months ago (2017-03-17 18:25:05 UTC) #7
pfeldman
all done
3 years, 9 months ago (2017-03-20 19:30:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753183002/20001
3 years, 9 months ago (2017-03-20 19:30:25 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 21:06:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d1cb28855c8d2d3413fda1655bd7...

Powered by Google App Engine
This is Rietveld 408576698