Ensure that with PlzNavigate, reloads after process crash display the RenderView.

Ensure that with PlzNavigate, reloads after process crash display the RenderView.

BUG=699384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2753093002
Cr-Commit-Position: refs/heads/master@{#457626}
Committed: https://chromium.googlesource.com/chromium/src/+/8e07fc9bf21eaec35f94de57f9ba20cc5a9b009e

[jam, 2017-03-16 20:59:51]

Description was changed from

==========
Ensure that with PlzNavigate, reloads after process crash display the
RenderView.

BUG=699384
==========

to

==========
Ensure that with PlzNavigate, reloads after process crash display the
RenderView.

BUG=699384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-03-16 21:00:33]

jam@chromium.org changed reviewers:
+ nasko@chromium.org

[jam, 2017-03-16 21:00:39]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:01:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2017-03-16 21:53:15]

LGTM with a nit.

https://codereview.chromium.org/2753093002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.h (right):

https://codereview.chromium.org/2753093002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.h:753: // After a renderer
crash we'd have marked the host as invisible, so we need
nit: "renderer process"

[commit-bot: I haz the power, 2017-03-16 22:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 22:25:02]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-16 23:04:27]

https://codereview.chromium.org/2753093002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.h (right):

https://codereview.chromium.org/2753093002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.h:753: // After a renderer
crash we'd have marked the host as invisible, so we need
On 2017/03/16 21:53:15, nasko (slow) wrote:
> nit: "renderer process"

done, but curious why renderer is not sufficient?

[jam, 2017-03-16 23:05:19]

The CQ bit was checked by jam@chromium.org

[jam, 2017-03-16 23:05:20]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2753093002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-03-16 23:05:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2017-03-16 23:08:10]

On 2017/03/16 23:04:27, jam wrote:
>
https://codereview.chromium.org/2753093002/diff/1/content/browser/frame_host/...
> File content/browser/frame_host/render_frame_host_manager.h (right):
> 
>
https://codereview.chromium.org/2753093002/diff/1/content/browser/frame_host/...
> content/browser/frame_host/render_frame_host_manager.h:753: // After a
renderer
> crash we'd have marked the host as invisible, so we need
> On 2017/03/16 21:53:15, nasko (slow) wrote:
> > nit: "renderer process"
> 
> done, but curious why renderer is not sufficient?

"renderer" can be either the RenderFrame or the process and it helps being more
precise about which one is meant. I found reading too many comments that were
ambiguous about it and it was hard to figure out the intent, so I've decided to
ask for more specific wording.

[jam, 2017-03-16 23:13:11]

On Thu, Mar 16, 2017 at 4:08 PM, <nasko@chromium.org> wrote:

> On 2017/03/16 23:04:27, jam wrote:
> >
> https://codereview.chromium.org/2753093002/diff/1/content/
> browser/frame_host/render_frame_host_manager.h
> > File content/browser/frame_host/render_frame_host_manager.h (right):
> >
> >
> https://codereview.chromium.org/2753093002/diff/1/content/
> browser/frame_host/render_frame_host_manager.h#newcode753
> > content/browser/frame_host/render_frame_host_manager.h:753: // After a
> renderer
> > crash we'd have marked the host as invisible, so we need
> > On 2017/03/16 21:53:15, nasko (slow) wrote:
> > > nit: "renderer process"
> >
> > done, but curious why renderer is not sufficient?
>
> "renderer" can be either the RenderFrame or the process and it helps being
> more
> precise about which one is meant. I found reading too many comments that
> were
> ambiguous about it and it was hard to figure out the intent, so I've
> decided to
> ask for more specific wording.
>

hmm, I've never referred to RF as the renderer or seen it referred to that
way, but ok.


>
> https://codereview.chromium.org/2753093002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-03-17 00:34:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489705519550980,
"parent_rev": "ce6b684e85eb02e3ff92e9b5e84fe2cfd1908f8f", "commit_rev":
"8e07fc9bf21eaec35f94de57f9ba20cc5a9b009e"}

[commit-bot: I haz the power, 2017-03-17 00:36:20]

Description was changed from

==========
Ensure that with PlzNavigate, reloads after process crash display the
RenderView.

BUG=699384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Ensure that with PlzNavigate, reloads after process crash display the
RenderView.

BUG=699384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2753093002
Cr-Commit-Position: refs/heads/master@{#457626}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e07fc9bf21eaec35f94de57f9ba...
==========

[commit-bot: I haz the power, 2017-03-17 00:36:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e07fc9bf21eaec35f94de57f9ba...