|
|
DescriptionCreate new versions of SerializeXXX() functions that uses pre-allocated buffer in SpdyFrameBuilder.
This CL lands server change 147618543 by yasong.
BUG=488484
Review-Url: https://codereview.chromium.org/2753043002
Cr-Commit-Position: refs/heads/master@{#457852}
Committed: https://chromium.googlesource.com/chromium/src/+/5cb5d523c83566fb3508ed711cbc7d8f68811fdc
Patch Set 1 #Patch Set 2 : htonl change #
Total comments: 9
Patch Set 3 : address comments. #Patch Set 4 : rebase #Patch Set 5 : git cl format #
Messages
Total messages: 37 (31 generated)
The CQ bit was checked by yasong@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by yasong@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== format2 format The change in spdy_frame_builder.h/cc is to allow OverwriteLength() to be called when SpdyFrameBuilder writes to pre-allocated buffer. The change is a temporary fix before --gfe2_reloadable_flag_remove_rewritelength deprecates. This CL lands server change 147618543 by yasong. BUG=488484 ========== to ========== The change in spdy_frame_builder.h/cc is to allow OverwriteLength() to be called when SpdyFrameBuilder writes to pre-allocated buffer. The change is a temporary fix before --gfe2_reloadable_flag_remove_rewritelength deprecates. This CL lands server change 147618543 by yasong. BUG=488484 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== The change in spdy_frame_builder.h/cc is to allow OverwriteLength() to be called when SpdyFrameBuilder writes to pre-allocated buffer. The change is a temporary fix before --gfe2_reloadable_flag_remove_rewritelength deprecates. This CL lands server change 147618543 by yasong. BUG=488484 ========== to ========== Create new versions of SerializeXXX() functions that uses pre-allocated buffer in SpdyFrameBuilder. This CL lands server change 147618543 by yasong. BUG=488484 ==========
yasong@chromium.org changed reviewers: + bnc@chromium.org
On 2017/03/16 15:57:06, yasong wrote: > mailto:yasong@chromium.org changed reviewers: > + mailto:bnc@chromium.org Ready for review. Thanks!
Thank you. https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_frame_bui... File net/spdy/spdy_frame_builder.h (right): https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_frame_bui... net/spdy/spdy_frame_builder.h:143: // --gfe2_reloadable_flag_remove_rewritelength deprecates. s/--gfe2_reloadable_flag_write_queue_zero_copy_buffer/FLAGS_chromium_http2_flag_remove_rewritelength/ https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer.cc... net/spdy/spdy_framer.cc:1858: SpdySerializedFrame SpdyFramer::SerializeSettings( 9 lines were removed from this method and 6 added in the internal change, please merge them. https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer_te... File net/spdy/spdy_framer_test.cc (right): https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer_te... net/spdy/spdy_framer_test.cc:716: // gfe2_reloadable_flag_write_queue_zero_copy_buffer deprecates. s/gfe2_reloadable_flag_write_queue_zero_copy_buffer/FLAGS_chromium_http2_flag_remove_rewritelength/ https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer_te... net/spdy/spdy_framer_test.cc:1084: EXPECT_TRUE(framer.SerializeFrame(priority_ir, &output_)); Please use ASSERT_TRUE instead of EXPECT_TRUE, because that is closer to the internal code, here and below at multiple places.
The CQ bit was checked by yasong@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for the review! PTAL. https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_frame_bui... File net/spdy/spdy_frame_builder.h (right): https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_frame_bui... net/spdy/spdy_frame_builder.h:143: // --gfe2_reloadable_flag_remove_rewritelength deprecates. On 2017/03/16 18:12:54, Bence wrote: > s/--gfe2_reloadable_flag_write_queue_zero_copy_buffer/FLAGS_chromium_http2_flag_remove_rewritelength/ Done. https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer.cc... net/spdy/spdy_framer.cc:1858: SpdySerializedFrame SpdyFramer::SerializeSettings( On 2017/03/16 18:12:54, Bence wrote: > 9 lines were removed from this method and 6 added in the internal change, please > merge them. Nice catch!! How did find them? https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer_te... File net/spdy/spdy_framer_test.cc (right): https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer_te... net/spdy/spdy_framer_test.cc:716: // gfe2_reloadable_flag_write_queue_zero_copy_buffer deprecates. On 2017/03/16 18:12:54, Bence wrote: > s/gfe2_reloadable_flag_write_queue_zero_copy_buffer/FLAGS_chromium_http2_flag_remove_rewritelength/ Done. https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer_te... net/spdy/spdy_framer_test.cc:1084: EXPECT_TRUE(framer.SerializeFrame(priority_ir, &output_)); On 2017/03/16 18:12:54, Bence wrote: > Please use ASSERT_TRUE instead of EXPECT_TRUE, because that is closer to the > internal code, here and below at multiple places. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
LGTM. Unfortunately https://crrev.com/2750853008 landed in the meanwhile, there's two merge conflicts in spdy_framer_test.cc that you have to manually resolve. https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/2753043002/diff/20001/net/spdy/spdy_framer.cc... net/spdy/spdy_framer.cc:1858: SpdySerializedFrame SpdyFramer::SerializeSettings( On 2017/03/16 22:28:52, yasong wrote: > On 2017/03/16 18:12:54, Bence wrote: > > 9 lines were removed from this method and 6 added in the internal change, > please > > merge them. > > Nice catch!! How did find them? By going through the two diffs side by side. Unfortunately there's no easy way.
The CQ bit was checked by yasong@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by yasong@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yasong@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yasong@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org Link to the patchset: https://codereview.chromium.org/2753043002/#ps80001 (title: "git cl format")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489778051791330, "parent_rev": "7b5e4e437bb223e9fd68f749f7b3325356719180", "commit_rev": "5cb5d523c83566fb3508ed711cbc7d8f68811fdc"}
Message was sent while issue was closed.
Description was changed from ========== Create new versions of SerializeXXX() functions that uses pre-allocated buffer in SpdyFrameBuilder. This CL lands server change 147618543 by yasong. BUG=488484 ========== to ========== Create new versions of SerializeXXX() functions that uses pre-allocated buffer in SpdyFrameBuilder. This CL lands server change 147618543 by yasong. BUG=488484 Review-Url: https://codereview.chromium.org/2753043002 Cr-Commit-Position: refs/heads/master@{#457852} Committed: https://chromium.googlesource.com/chromium/src/+/5cb5d523c83566fb3508ed711cbc... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/5cb5d523c83566fb3508ed711cbc... |