MD Settings: Default browser message tweak.

MD Settings: Default browser message tweak.

BUG=673952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2752993002
Cr-Commit-Position: refs/heads/master@{#457586}
Committed: https://chromium.googlesource.com/chromium/src/+/17d00a1b464a2761035b184cb46d24612829ffd6

[scottchen, 2017-03-16 00:33:08]

Description was changed from

==========
MD Settings: Default browser message tweak.

BUG=673952
==========

to

==========
MD Settings: Default browser message tweak.

BUG=673952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-03-16 00:39:30]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 00:39:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:52:13]

Dry run: This issue passed the CQ dry run.

[scottchen, 2017-03-16 18:10:56]

scottchen@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2017-03-16 18:41:01]

https://codereview.chromium.org/2752993002/diff/20002/chrome/app/settings_goo...
File chrome/app/settings_google_chrome_strings.grdp (right):

https://codereview.chromium.org/2752993002/diff/20002/chrome/app/settings_goo...
chrome/app/settings_google_chrome_strings.grdp:42: Google Chrome is your default
browser.
What about the equivalent Chromium string? See
https://cs.chromium.org/chromium/src/chrome/app/settings_chromium_strings.grd....

https://codereview.chromium.org/2752993002/diff/20002/chrome/browser/resource...
File
chrome/browser/resources/settings/default_browser_page/default_browser_page.html
(right):

https://codereview.chromium.org/2752993002/diff/20002/chrome/browser/resource...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:28:
id="isDefault">
Nit: Does this fit in previous line now? Same question below.

[scottchen, 2017-03-16 18:56:25]

https://codereview.chromium.org/2752993002/diff/20002/chrome/app/settings_goo...
File chrome/app/settings_google_chrome_strings.grdp (right):

https://codereview.chromium.org/2752993002/diff/20002/chrome/app/settings_goo...
chrome/app/settings_google_chrome_strings.grdp:42: Google Chrome is your default
browser.
On 2017/03/16 18:41:00, dpapad wrote:
> What about the equivalent Chromium string? See
>
https://cs.chromium.org/chromium/src/chrome/app/settings_chromium_strings.grd....

Done.

https://codereview.chromium.org/2752993002/diff/20002/chrome/browser/resource...
File
chrome/browser/resources/settings/default_browser_page/default_browser_page.html
(right):

https://codereview.chromium.org/2752993002/diff/20002/chrome/browser/resource...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:28:
id="isDefault">
On 2017/03/16 18:41:01, dpapad wrote:
> Nit: Does this fit in previous line now? Same question below.

Not the second one, but did fix its indentation issue before "id". Moved the
other two to same line.

[dpapad, 2017-03-16 19:02:19]

lgtm

[scottchen, 2017-03-16 21:28:11]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-03-16 21:29:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 22:34:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489699691995760,
"parent_rev": "b920cc2cead86781d5c5882a22ed09793b144d63", "commit_rev":
"17d00a1b464a2761035b184cb46d24612829ffd6"}

[commit-bot: I haz the power, 2017-03-16 22:34:56]

Description was changed from

==========
MD Settings: Default browser message tweak.

BUG=673952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Default browser message tweak.

BUG=673952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2752993002
Cr-Commit-Position: refs/heads/master@{#457586}
Committed:
https://chromium.googlesource.com/chromium/src/+/17d00a1b464a2761035b184cb46d...
==========

[commit-bot: I haz the power, 2017-03-16 22:34:58]

Committed patchset #5 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/17d00a1b464a2761035b184cb46d...