|
|
Created:
3 years, 9 months ago by Marijn Kruisselbrink Modified:
3 years, 7 months ago CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd UMA histograms to mojo leveldb env
This adds more or less the same UMA histograms that are logged by the non-mojo
leveldb env to the mojo leveldb env.
BUG=586194
Review-Url: https://codereview.chromium.org/2752963002
Cr-Commit-Position: refs/heads/master@{#472844}
Committed: https://chromium.googlesource.com/chromium/src/+/339e6991a01df07f62d2e91ef220c2139d323d04
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : cleanup #Patch Set 4 : better logging #
Total comments: 2
Patch Set 5 : address comment #
Total comments: 1
Patch Set 6 : use UmaHistogramExactLinear convenience wrapper #
Messages
Total messages: 32 (22 generated)
The CQ bit was checked by mek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by mek@chromium.org to run a CQ dry run
Description was changed from ========== Make sure mojo leveldb env actually logs histograms. BUG=586194 ========== to ========== Add UMA histograms to mojo leveldb env This adds more or less the same UMA histograms that are logged by the non-mojo leveldb env to the mojo leveldb env. BUG=586194 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mek@chromium.org changed reviewers: + cmumford@chromium.org, isherman@chromium.org
lgtm % nit https://codereview.chromium.org/2752963002/diff/60001/components/leveldb/env_... File components/leveldb/env_mojo.cc (right): https://codereview.chromium.org/2752963002/diff/60001/components/leveldb/env_... components/leveldb/env_mojo.cc:393: std::pair<filesystem::mojom::FileError, LevelDBMojoProxy::OpaqueLock*> p = Can remove namespaces on this FileError (and below).
The CQ bit was checked by mek@chromium.org to run a CQ dry run
https://codereview.chromium.org/2752963002/diff/60001/components/leveldb/env_... File components/leveldb/env_mojo.cc (right): https://codereview.chromium.org/2752963002/diff/60001/components/leveldb/env_... components/leveldb/env_mojo.cc:393: std::pair<filesystem::mojom::FileError, LevelDBMojoProxy::OpaqueLock*> p = On 2017/05/17 at 17:58:37, cmumford wrote: > Can remove namespaces on this FileError (and below). Done
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Metrics LGTM https://codereview.chromium.org/2752963002/diff/80001/components/leveldb/env_... File components/leveldb/env_mojo.cc (right): https://codereview.chromium.org/2752963002/diff/80001/components/leveldb/env_... components/leveldb/env_mojo.cc:457: ->Add(-error); nit: Please use the convenience wrapper base::UmaHistogramExactLinear here.
The CQ bit was checked by mek@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cmumford@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2752963002/#ps100001 (title: "use UmaHistogramExactLinear convenience wrapper")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495118051238220, "parent_rev": "17f8996369a1f34616def9551c2f9036348877ff", "commit_rev": "339e6991a01df07f62d2e91ef220c2139d323d04"}
Message was sent while issue was closed.
Description was changed from ========== Add UMA histograms to mojo leveldb env This adds more or less the same UMA histograms that are logged by the non-mojo leveldb env to the mojo leveldb env. BUG=586194 ========== to ========== Add UMA histograms to mojo leveldb env This adds more or less the same UMA histograms that are logged by the non-mojo leveldb env to the mojo leveldb env. BUG=586194 Review-Url: https://codereview.chromium.org/2752963002 Cr-Commit-Position: refs/heads/master@{#472844} Committed: https://chromium.googlesource.com/chromium/src/+/339e6991a01df07f62d2e91ef220... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/339e6991a01df07f62d2e91ef220... |