[Fasta] Do not emit default arguments at callsite

[Fasta] Do not emit default arguments at callsite

Fixes a couple of performance regressions (RegExp, ParticleSystem).

BUG= https://github.com/dart-lang/sdk/issues/29089
R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/451882daf72c8ae838039258096ac25d1751edaa

[Dmitry Olshansky, 2017-03-16 14:40:54]

Description was changed from

==========
[Fasta] Do not emit default arguments at callsite

BUG= https://github.com/dart-lang/sdk/issues/29089
==========

to

==========
[Fasta] Do not emit default arguments at callsite

Fixes a couple of performance regressions (RegExp, ParticleSystem).

BUG= https://github.com/dart-lang/sdk/issues/29089
==========

[Dmitry Olshansky, 2017-03-16 14:41:05]

dmitryolsh@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-03-16 14:48:34]

lgtm

https://codereview.chromium.org/2752943003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (left):

https://codereview.chromium.org/2752943003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1692:
library.addArgumentsWithMissingDefaultValues(arguments, function);
Could you check if you can remove this method as well?

[Dmitry Olshansky, 2017-03-16 15:18:54]

https://codereview.chromium.org/2752943003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (left):

https://codereview.chromium.org/2752943003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1692:
library.addArgumentsWithMissingDefaultValues(arguments, function);
On 2017/03/16 14:48:33, ahe wrote:
> Could you check if you can remove this method as well?

Done.

[Dmitry Olshansky, 2017-03-16 15:19:41]

Description was changed from

==========
[Fasta] Do not emit default arguments at callsite

Fixes a couple of performance regressions (RegExp, ParticleSystem).

BUG= https://github.com/dart-lang/sdk/issues/29089
==========

to

==========
[Fasta] Do not emit default arguments at callsite

Fixes a couple of performance regressions (RegExp, ParticleSystem).

BUG= https://github.com/dart-lang/sdk/issues/29089
R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/451882daf72c8ae838039258096ac25d1751edaa
==========

[Dmitry Olshansky, 2017-03-16 15:19:42]

Committed patchset #2 (id:20001) manually as
451882daf72c8ae838039258096ac25d1751edaa (presubmit successful).

[ahe, 2017-03-16 15:37:35]

FYI: Let me know if you prefer that I remove this?

https://codereview.chromium.org/2752943003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart (left):

https://codereview.chromium.org/2752943003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart:343:
argumentsWithMissingDefaultValues.add([arguments, function]);
We can also remove this field, and all methods that use it.

[Dmitry Olshansky, 2017-03-16 16:38:49]

On 2017/03/16 15:37:35, ahe wrote:
> FYI: Let me know if you prefer that I remove this?

Yeah I'd prefer if you cut down them.
I think you would have better idea about 
the whole chain of things that are now unused.


> 
>
https://codereview.chromium.org/2752943003/diff/20001/pkg/front_end/lib/src/f...
> File pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart (left):
> 
>
https://codereview.chromium.org/2752943003/diff/20001/pkg/front_end/lib/src/f...
> pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart:343:
> argumentsWithMissingDefaultValues.add([arguments, function]);
> We can also remove this field, and all methods that use it.